Skip to content

fix(viewer): kick render on focus and visibility resume #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

fix(viewer): kick render on focus and visibility resume #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/viewer/src/components/viewer/frame-limiter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,31 @@ const FrameLimiter: React.FC<FrameLimiterProps> = ({ fps = 50 }) => {
set({ frameloop: 'never' })
raf = requestAnimationFrame(tick)

// Browsers throttle requestAnimationFrame when the tab is hidden, the
// window is unfocused, or the system marks the tab as occluded. With
// frameloop="never" rAF is the only render driver, so when it stalls the
// canvas freezes — Linux Firefox/Chrome and Zen show this as the viewer
// "turning off" between cursor interactions. Force one synchronous
// advance whenever the page resumes so the next visible frame matches the
// current scene state.
function kick() {
i += 1 / 1000
advance(i)
}
function onVisibilityChange() {
if (document.visibilityState === 'visible') kick()
}
document.addEventListener('visibilitychange', onVisibilityChange)
window.addEventListener('focus', kick)
window.addEventListener('pageshow', kick)

return () => {
if (raf) {
cancelAnimationFrame(raf)
}
document.removeEventListener('visibilitychange', onVisibilityChange)
window.removeEventListener('focus', kick)
window.removeEventListener('pageshow', kick)
set({ frameloop: initFrameloop })
}
}, [fps, advance, set, initFrameloop])
Expand Down