This repository was archived by the owner on Dec 30, 2018. It is now read-only.
fix(masonry.restrict): change directive restriction to attribute-only#190
Open
blakerego wants to merge 1 commit intopassy:masterfrom
Open
fix(masonry.restrict): change directive restriction to attribute-only#190blakerego wants to merge 1 commit intopassy:masterfrom
blakerego wants to merge 1 commit intopassy:masterfrom
Conversation
The masonry directive does not properly create columns when used as an element. To avoid confusion, I updated the directive code to restrict usage to attribute mode only (this could always be changed back, if a subsequent fix was made to fix element loading). I have also updated the repository README documentation to provide a more accurate account of how the masonry directive currently works. This issue was first brought up here: passy#169 This will invalidate uses of this directive as an element. However, these uses are likely already
Owner
|
Interesting. Thanks for the investigation! Could you add a "Breaking Change" note to your commit message as described here? I'd like to cut a regular release first as this will require a major version bump. |
passy
approved these changes
Mar 14, 2017
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The masonry directive does not properly create columns when used as an element. To avoid confusion, I updated the directive code to restrict usage to attribute mode only (this could always be changed back, if a subsequent fix was made to fix element loading). I have also updated the repository README documentation to provide a more accurate account of how the masonry directive currently works. This issue was first brought up here: #169. Also updated the tests to reflect this change.
This will break uses of this directive as an element. However, these uses are likely already broken.