Handle Y offsets in EH preview sprites, migrate preview cache to v2, and update UI#23
Closed
patrick3399 wants to merge 1 commit intomainfrom
Closed
Handle Y offsets in EH preview sprites, migrate preview cache to v2, and update UI#23patrick3399 wants to merge 1 commit intomainfrom
patrick3399 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
offsetYfield.Description
eh:previews:{gid}toeh:previews:v2:{gid}inbackend/services/cache.pyto version the cache.backend/services/eh_client.pyto extract both X and Y offsets from new and legacy preview formats, and to store previews asurl|offsetX|offsetY|width|height(legacyoffsetYomitted handled)._parse_detail_htmlnow computes and applies sprite max heights for the new 5-field format.pwa/src/app/browse/[gid]/[token]/page.tsx) updatedPreviewGridand preview parsing to accept and normalizeoffsetYand to use both offsets when rendering sprite backgrounds.pwa/src/components/Reader/index.tsxupdatedThumbnailStripto parse optionaloffsetY, normalize offsets, and include vertical offset inbackgroundPositionandbackgroundSizecalculations.pwa/src/lib/types.tsand inline comments to document the new preview string format and legacy handling.Testing
pytestand the suite completed successfully.pnpm install+pnpm build/tsc) and the TypeScript build succeeded without errors.Codex Task