Skip to content

fix(lotw): normalize CRLF to LF in tCERT body so LoTW accepts uploads #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickrb merged 1 commit into from
May 12, 2026
Merged

fix(lotw): normalize CRLF to LF in tCERT body so LoTW accepts uploads #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/lib/lotw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,19 @@ function parseP12(buf: Buffer, password: string): ParsedP12 {
const privateKeyPem = forge.pki.privateKeyToPem(keyBag.key);
const certPem = forge.pki.certificateToPem(certBag.cert);

// Strip exactly the BEGIN/END markers; keep internal newlines unchanged
// (LoTW's parser expects multi-line PEM bodies).
// Strip exactly the BEGIN/END markers, keep internal newlines, and normalize
// CRLF to LF. node-forge emits PEM with \r\n (pem.js, util.js encode64), but
// wavelog's reference .tq8 is produced from PHP's openssl_x509_export which
// uses \n only. LoTW silently rejects the QSOs in a file whose tCERT body
// doesn't match TQSL's expected line-ending convention (the file is still
// queued for processing — the "<!-- .UPL. accepted -->" marker just means
// the multipart POST was received — but the processor drops everything
// before the "Last upload" timestamp moves).
const certPemBody = certPem
.replace(/-----BEGIN CERTIFICATE-----\s*/g, '')
.replace(/-----END CERTIFICATE-----\s*/g, '')
.replace(/\r\n/g, '\n')
.replace(/\r/g, '\n')
.trim();

// ARRL embeds DXCC entity ID in a private extension (PrintableString).
Expand Down
Loading