scrub: report VCS errors instead of silent swallow#22
Open
nothingmuch wants to merge 1 commit into
Open
Conversation
The revset resolution step redirected both stdout and stderr to /dev/null, so VCS failures (bad revset, incompatible index, missing repo) silently produced an empty commit list and printed the misleading message "No commits in range." Now capture stdout into a variable (stderr flows through to the caller directly). Check exit codes and bail on failure. On the jj side, the elif chain is simplified: the use_log_revset case falls through with no -r flag (jj uses its default revset), removing a redundant branch. The git side keeps its parallel structure unchanged.
nothingmuch
force-pushed
the
scrub-error-reporting
branch
from
dc3a9d1 to
7ca7991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revset resolution step redirected both stdout and stderr to /dev/null, so VCS failures (bad revset, incompatible index, missing repo) silently produced an empty commit list and printed the misleading message "No commits in range."