nix: crane check improvements#23
Open
nothingmuch wants to merge 1 commit into
Open
Conversation
nothingmuch
force-pushed
the
shortrev-check-names
branch
from
4598651 to
edaf78b
Compare
Introduces checkArgs and use it in all check derivations. It modifies commonArgs: version = shortRev makes each derivation name include the commit hash, so both nix log output and nom tree display distinguish checks across commits during scrubbing. doInstallCargoArtifacts = false skips installation of cargo artifacts (used for caching deps in crane derivations). dontFixup = true skips patchelf/RPATH shrinking for check derivations that have no installable output. Replace CARGO_PROFILE = "dev" with CARGO_PROFILE = "" in coverage and clippy derivations. When empty, crane's cargoWithProfile injects no --profile flag, letting cargo choose the appropriate profile for each command (dev for check/test, release for build). Note that crane's default is "release", which is a the default for package builds with workspace dependency caching.
nothingmuch
force-pushed
the
shortrev-check-names
branch
from
edaf78b to
66e7356
Compare
bc1cindy
reviewed
May 28, 2026
| // { | ||
| cargoArtifacts = cargoArtifactsDev; | ||
| CARGO_PROFILE = "dev"; | ||
| CARGO_PROFILE = ""; |
There was a problem hiding this comment.
nit: since checkArgs already sets CARGO_PROFILE = "" on line 18, isnt this redundant here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors and cleans up some crane related derivations.