Fix payjoin-cli receiver premature resolution#1575
Draft
xstoicunicornx wants to merge 1 commit into
Draft
Conversation
Collaborator
Coverage Report for CI Build 26318861359Coverage increased (+0.05%) to 85.185%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
|
@xstoicunicornx i don’t know if you saw it but I already opened a Pr in #1573 and also delegated it to myself in issue |
Collaborator
Author
|
Yeah sorry about that... just posted in the issue: #1545 (comment) When I last looked this morning there was no PR published and thought maybe I should just take care of it quick. |
af91f7e to
4c4147d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1545
Currently the payjoin-cli receiver will return an "All resumed sessions completed." message even when the session did not progress to completion. This was due to:
Test has been updated to enforce that receiver should not return completed message when session was not completed.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.