Skip to content

Fix payjoin-cli receiver premature resolution#1575

Draft
xstoicunicornx wants to merge 1 commit into
payjoin:masterfrom
xstoicunicornx:fix-cli-receiver-inaccurate-complete
Draft

Fix payjoin-cli receiver premature resolution#1575
xstoicunicornx wants to merge 1 commit into
payjoin:masterfrom
xstoicunicornx:fix-cli-receiver-inaccurate-complete

Conversation

@xstoicunicornx
Copy link
Copy Markdown
Collaborator

Summary

Resolves #1545

Currently the payjoin-cli receiver will return an "All resumed sessions completed." message even when the session did not progress to completion. This was due to:

  • Not appropriately handling the stasis outcome
  • Not appropriately handling the timeout for resumed receiver session

Test has been updated to enforce that receiver should not return completed message when session was not completed.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 22, 2026

Coverage Report for CI Build 26318861359

Coverage increased (+0.05%) to 85.185%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: 3 uncovered changes across 1 file (16 of 19 lines covered, 84.21%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
payjoin-cli/src/app/v2/mod.rs 19 16 84.21%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13716
Covered Lines: 11684
Line Coverage: 85.19%
Coverage Strength: 394.72 hits per line

💛 - Coveralls

@zealsham
Copy link
Copy Markdown
Collaborator

@xstoicunicornx i don’t know if you saw it but I already opened a Pr in #1573 and also delegated it to myself in issue

@xstoicunicornx
Copy link
Copy Markdown
Collaborator Author

Yeah sorry about that... just posted in the issue: #1545 (comment)

When I last looked this morning there was no PR published and thought maybe I should just take care of it quick.

@xstoicunicornx xstoicunicornx force-pushed the fix-cli-receiver-inaccurate-complete branch from af91f7e to 4c4147d Compare May 23, 2026 00:46
@xstoicunicornx xstoicunicornx marked this pull request as draft May 25, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

payjoin-cli resume succeeds prematurely

3 participants