fix(cli): v1 config rejecting endpoints without explicit port#1576
Open
va-an wants to merge 2 commits into
Open
fix(cli): v1 config rejecting endpoints without explicit port#1576va-an wants to merge 2 commits into
va-an wants to merge 2 commits into
Conversation
State the port check's single invariant directly: `--port 0` (let the OS pick) is incompatible with a `--pj-endpoint` URL that pins a specific port.
Collaborator
Coverage Report for CI Build 26398782191Coverage increased (+0.05%) to 85.192%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> % payjoin-cli --bip78 --port 3000 --pj-endpoint https://example.com/ receive 50000 Error: If --port is 0, --pj-endpoint may not have a portTwo problems here:
--portis 3000, not 0.Pull Request Checklist
Please confirm the following before requesting review: