Add tests for OriginalPayload and PsbtContext#1583
Open
xstoicunicornx wants to merge 1 commit into
Open
Conversation
Cover the success and error paths for each validation step in the receiver's OriginalPayload's broadcast suitability, input ownership, and input known validation as well as PsbtContext's proposal finalization.
Collaborator
Coverage Report for CI Build 26541650378Coverage increased (+0.1%) to 85.254%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
OriginalPayload's validation methods andPsbtContext's finalization method do not have explicit tests that exercise all possible errors that may arise when call. This PR creates tests that cover the success and error paths for each validation step in the receiver'sOriginalPayload(broadcast suitability, input ownership, and input known validation) as well as PsbtContext's proposal finalization.These tests were written in preparation of implementing PR 1446.
Claude AI was used to generate these tests.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.