FFI: Refactor Javascript integration test#1584
Open
xstoicunicornx wants to merge 1 commit into
Open
Conversation
Consolidate standalone receiver processing functions into a ReceiverProcessor class that encapsulates the payjoin module, RPC client, and persister. Fix the PJ helper type to use prototype inference, update the web import paths from src to dist, and correct the CheckInputsNotSeenCallback parameter type.
Collaborator
Coverage Report for CI Build 26542886374Coverage remained the same at 85.14%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are a few things this refactor aims to address:
srcfolder when the distributed code actually lives in thedistfoldertype PJ<K extends keyof PayjoinModule>is casting toanytype rather than the actual type of the payjoin module memberCheckInputsNotSeenCallbackcallback parameter is typed as anArrayBufferwhen it should beOutPointThis refactor was written in preparation of implementing PR 1446. PR 1446 will add an additional test permutation to this integration test and benefit from this refactor.
This refactor was written with the help of Claude AI.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.