Closed
Conversation
- Add complete PCRE2 10.42 source tree in src/pcre2/ - Includes all headers, source files, and build configuration - No functional changes, pure vendor import
- Delete src/pcre/ directory and all PCRE v1 files - No functional impact, just cleanup before PCRE2 migration
…ange - Add regex wrapper (src/regex.h, src/regex.c) for PCRE v1 → PCRE2 compatibility - Update build.zig to use vendored PCRE2 with flexible linking options - Update cli.h and memory.h to use regex.h instead of pcre/pcre.h - Update .gitignore to allow .gitattributes and .git-blame-ignore-revs - Maintains exact same API and behavior, just internal implementation change
- Add missing CI workflow files (.github/workflows/) - Restore original python/src/fastfec/utils.py with proper library detection - Add missing python build files (make_wheels.py, pyproject.toml, requirements-dev.txt) - Add benchmark script and README updates - All tests now pass: C tests (21/21), Python tests (8/8)
- Change WASM build from addExecutable to addSharedLibrary - This puts the .wasm file in zig-out/lib/ instead of zig-out/bin/ - Fixes CI error: 'mv zig-out/lib/fastfec.wasm libfastfec-latest.wasm' - WASM file now appears in the expected location for release workflow
- On Windows, Zig places DLLs in zig-out/bin, not zig-out/lib - Split move step into Windows vs non-Windows - Keeps existing behavior for Linux/macOS and WASM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: PCRE v1 → PCRE2 Migration with Zig 0.14+ Support
Overview
Migrates FastFEC from end-of-life PCRE v1 to PCRE2 while adding Zig 0.14+ support and cleaning up the build system.
Why This Change
What Changed
src/pcre2/src/regex.handsrc/regex.cto maintain API compatibilitybuild.zigfor Zig 0.14+ with flexible PCRE2 linkingKey Features
-Dvendored-pcreoption (defaults to true)Test Results
Build Options
Files Changed
Ready for merge ✅ - All tests passing, no breaking changes.