feat: vmdi missing image self heal #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallquist10
reviewed
Dec 16, 2025
tallquist10
previously approved these changes
Dec 16, 2025
Collaborator
Author
|
I have not forgotten about this PR. I'll come back to finalize it once priorities ship back |
hmbill694
force-pushed
the
feat/vmdi-missing-image-self-heal
branch
from
dca4302 to
bdbe599
Compare
… is ~3 so lets us do 4 labs
tallquist10
approved these changes
Jan 12, 2026
tallquist10
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Howdy, howdy gang! I've gone ahead and updated the VMDI to handle the case of missing artifacts. I've done so by revamping how the error handling works. Before we would try a certain amount of times and then immediately fail out. Now we retry with an exponential backoff. Resources will hang around in a new "RetryableFailure" state until they are queued again.
Once this lands I think we can turn autosync on 👀
Demo
A contrived demo where the timeout is the max sync time is one minute and the retry backoff max is 15 seconds
vmdi-demo.mov
TIL
Kubebuilder reconcilers will require immediately whenever the resource we are passing through the reconcile loop is changed regardless if the reconcile loop also returns a result that result in a requeue at a later time. Because of this there are some small changes to orchestration return types and stuff of that nature.