✨ Make the common fressian module more testable#8859
Merged
Conversation
Add a JVM-only test suite (41 tests, 172 assertions) for the fressian serialisation layer, covering: - All custom handlers: char, clj/keyword, clj/symbol, clj/vector, clj/set, clj/map, clj/seq, clj/ratio, clj/bigint, java/instant, OffsetDateTime, linked/map (order preserved), linked/set (order preserved) - Built-in types: nil, boolean, int, long, double (NaN, ±Inf, boundaries), String, byte[], UUID - Edge cases: empty collections, nil values, ArrayMap/HashMap size boundary, mixed key types - Penpot-domain structures: shape maps with UUID keys, nested objects maps - Correctness: encode→decode→encode idempotency, independent encode calls
Extract adapt-write-handler, adapt-read-handler, and merge-handlers out of the letfn in add-handlers! into reusable private functions. Also creates xf:adapt-write-handler and xf:adapt-read-handler transducers and adds overwrite-read-handlers and overwrite-write-handlers for advanced handler override use cases.
niwinz
changed the title
luisddm
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the common freesian module more testable and add several additional tests