Open
Conversation
details/summary要素を使ったdisclosureコンポーネントを追加。 cellのmixinに準拠したsize・densityプロパティを持ち、hover/focus時のインタラクションスタイルもadapter関数を使って実装。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
stylelint-config-rational-order に従い、list-style を background-color より前に移動。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
どのサイズにおいてもxsが最適に見えたのでxs固定で良いと判断した
yamaki0405
approved these changes
Apr 2, 2026
yamaki0405
left a comment
yamaki0405
left a comment
There was a problem hiding this comment.
ご対応ありがとうございます。
1つコメントをしましたが、クリティカルではないのでapproveしています。
Comment on lines
+40
to
+43
| <Icon | ||
| className='_icon' | ||
| icon='chevron_right' | ||
| /> |
There was a problem hiding this comment.
aria-hidden="true"をつけてもいいのかなって思いました。
Collaborator
Author
There was a problem hiding this comment.
@yamaki0405
Iconコンポーネントにaria-hiddenのpropsを追加すればできるので、このPRでは単にDisclosureの追加に留めて、別でIconコンポーネントへのprops追加（およびaria-hiddenを付与するべき他のStorybook内コンポーネントの精査・追加）しましょうかね
# Conflicts: # package-lock.json # packages/components-web/package.json # packages/stories-web/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disclosureコンポーネントを追加します。マークアップはdetails/summary要素を想定していますが、React-ARIAなどライブラリの活用も見据えています。
packages/cellに準拠したsize・densityプロパティを備えています。