Skip to content

PMM-14829 Remove crypto package fork usage.#5115

Merged
JiriCtvrtka merged 21 commits intov3from
PMM-14829-remove-crypto-fork
Mar 17, 2026
Merged

PMM-14829 Remove crypto package fork usage.#5115
JiriCtvrtka merged 21 commits intov3from
PMM-14829-remove-crypto-fork

Conversation

@JiriCtvrtka
Copy link
Copy Markdown
Contributor

@JiriCtvrtka JiriCtvrtka commented Mar 6, 2026

PMM-14829

FB: Percona-Lab/pmm-submodules#4257

This PR removes the project’s dependency on the Percona-Lab fork of golang.org/x/crypto and adjusts the local bcrypt implementation so the codebase can use the upstream golang.org/x/crypto/bcrypt module.

Most of the code was copied from golang.org/x/crypto/bcrypt. I made edits to satisfy linters. The functions GenerateFromPasswordAndSalt and newFromPasswordAndSalt are ours.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 79.54545% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.76%. Comparing base (46df6bf) to head (43f9ac9).
⚠️ Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
managed/utils/crypto/bcrypt/bcrypt.go 79.54% 9 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #5115      +/-   ##
==========================================
+ Coverage   47.69%   47.76%   +0.06%     
==========================================
  Files         409      410       +1     
  Lines       41881    41969      +88     
==========================================
+ Hits        19977    20047      +70     
- Misses      19936    19945       +9     
- Partials     1968     1977       +9     
Flag Coverage Δ
admin 35.80% <ø> (ø)
agent 53.23% <ø> (ø)
managed 47.71% <79.54%> (+0.10%) ⬆️
vmproxy 72.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@percona percona deleted a comment from percona-robot Mar 6, 2026
@percona percona deleted a comment from percona-robot Mar 6, 2026
@percona percona deleted a comment from percona-robot Mar 6, 2026
@percona percona deleted a comment from percona-robot Mar 6, 2026
@percona percona deleted a comment from percona-robot Mar 6, 2026
@percona percona deleted a comment from percona-robot Mar 6, 2026
@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review March 6, 2026 16:41
@JiriCtvrtka JiriCtvrtka requested a review from a team as a code owner March 6, 2026 16:41
@JiriCtvrtka JiriCtvrtka requested review from ademidoff and maxkondr and removed request for a team March 6, 2026 16:41
Comment thread managed/utils/crypto/bcrypt/bcrypt.go Outdated
Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
@JiriCtvrtka JiriCtvrtka requested a review from ademidoff March 6, 2026 18:02
@JiriCtvrtka JiriCtvrtka merged commit 812d789 into v3 Mar 17, 2026
31 checks passed
@JiriCtvrtka JiriCtvrtka deleted the PMM-14829-remove-crypto-fork branch March 17, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants