PMM-14829 Remove crypto package fork usage.#5115
Merged
JiriCtvrtka merged 21 commits intov3from Mar 17, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #5115 +/- ##
==========================================
+ Coverage 47.69% 47.76% +0.06%
==========================================
Files 409 410 +1
Lines 41881 41969 +88
==========================================
+ Hits 19977 20047 +70
- Misses 19936 19945 +9
- Partials 1968 1977 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
reviewed
Mar 6, 2026
Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
maxkondr
approved these changes
Mar 9, 2026
ademidoff
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14829
FB: Percona-Lab/pmm-submodules#4257
This PR removes the project’s dependency on the Percona-Lab fork of golang.org/x/crypto and adjusts the local bcrypt implementation so the codebase can use the upstream golang.org/x/crypto/bcrypt module.
Most of the code was copied from golang.org/x/crypto/bcrypt. I made edits to satisfy linters. The functions GenerateFromPasswordAndSalt and newFromPasswordAndSalt are ours.