Wayland support by perk11 · Pull Request #4 · perk11/runwhenidle

perk11 · 2026-03-15T19:12:56Z

No description provided.

Clarified Wayland support status and updated known issues section.

… logic as it is not really needed

Copilot

Pull request overview

This PR introduces initial Wayland support for runwhenidle by using the ext_idle_notification_v1 protocol, while keeping the existing X11/XScreenSaver polling as a fallback. It also adds helpers to infer missing graphical-session environment variables and a few small utility modules needed by the new backend.

Changes:

Add a Wayland idle backend (ext-idle-notify) with a poll-based event loop and PID-exit monitoring.
Add “best effort” inference for XDG_RUNTIME_DIR, WAYLAND_DISPLAY, and DISPLAY plus basic file/string utilities.
Update build/linking and README to reflect Wayland support and new sources.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
wayland.h	Declares Wayland idle monitoring entry points.
wayland.c	Implements Wayland connection/registry binding and idle notification object management.
environment_guessing.h	Declares helpers to infer session env vars and open X11 display best-effort.
environment_guessing.c	Implements env inference + Wayland/X11 socket discovery logic.
ext-idle-notify-v1-client-protocol.h	Generated client header for ext-idle-notify-v1 protocol.
ext-idle-notify-v1-protocol.c	Generated protocol interface definitions for linking against libwayland-client.
main.c	Integrates Wayland event loop first, then falls back to X11 polling; adds SIGCHLD handling and timer/poll logic.
process_handling.h	Exposes a helper to open a pidfd for process-exit monitoring.
process_handling.c	Implements pidfd open via `syscall()` with ENOSYS fallback.
file_utils.h	Declares filesystem helpers used by environment inference.
file_utils.c	Implements socket/dir/file checks and home-dir lookup.
string_utils.h	Declares `is_string_null_or_empty`.
string_utils.c	Implements `is_string_null_or_empty`.
README.md	Documents Wayland vs X11 behavior and updates known-issues note.
Makefile	Links Wayland client library and builds the new sources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+                    command_paused = 1;
+                }
+            }
        }


Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.

Comments suppressed due to low confidence (1)

main.c:464

After introducing the resume_paused_command_on_user_idle() helper, the original inline logic (the if (!quiet) printf block, the call to resume_command_recursively(pid), and the command_paused = 0 assignment) was not removed. As a result, when the user becomes idle and the command is resumed, the "Lack of user activity detected." message is printed twice and resume_command_recursively(pid) is invoked twice. The duplicated block should be deleted.

            resume_paused_command_on_user_idle();
            if (!quiet) {
                printf("Lack of user activity detected. ");
                //intentionally no new line here, resume_command will print the rest of the message.
            }
            resume_command_recursively(pid);
            command_paused = 0;

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

… suffixes starting with a digit (e.g., `wayland-1abc`) were incorrectly accepted and parsed as numeric.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

main.c:466

After extracting the resume helper, the original message-and-resume block was kept in place. The result is that when the user becomes idle on X11, resume_paused_command_on_user_idle() first prints "Lack of user activity detected." and calls resume_command_recursively(pid), and then lines 461–466 print the same message and call resume_command_recursively(pid) a second time. The command is resumed twice (sending SIGCONT to an already-running process is harmless but misleading) and the user-facing message is duplicated. The leftover if (!quiet) { printf(...); } + resume_command_recursively(pid); command_paused = 0; block should be removed since resume_paused_command_on_user_idle() already performs all of it.

            resume_paused_command_on_user_idle();
            if (!quiet) {
                printf("Lack of user activity detected. ");
                //intentionally no new line here, resume_command will print the rest of the message.
            }
            resume_command_recursively(pid);
            command_paused = 0;

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

main.c:465

Duplicate resume on idle: resume_paused_command_on_user_idle() already prints "Lack of user activity detected. ", calls resume_command_recursively(pid), and sets command_paused = 0. The block below it (lines 460–465) repeats all three steps, so on every idle transition the command is resumed twice and the message is printed twice. Remove the duplicated block.

            resume_paused_command_on_user_idle();
            if (!quiet) {
                printf("Lack of user activity detected. ");
                //intentionally no new line here, resume_command will print the rest of the message.
            }
            resume_command_recursively(pid);
            command_paused = 0;

…m_home_dir` where a long home directory path could lead to an incorrect `.Xauthority` path. README

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.

+    if (wayland_seat == NULL || wayland_idle_notifier == NULL) {
+        wl_registry_destroy(wayland_registry);
+        wayland_registry = NULL;
+        wl_display_disconnect(wayland_display);
+        wayland_display = NULL;
+        wayland_seat = NULL;
+        wayland_idle_notifier = NULL;
+        wayland_idle_notify_available = 0;
+        return 0;
+    }


+    process_exit_wait_file_descriptor = open_pid_file_descriptor_for_process(pid);
+    if (process_exit_wait_file_descriptor == -1) {
+        const int saved_errno = errno;
+        fprintf_error("Failed to open file descriptor for pid %d: %s\n", pid, strerror(saved_errno));
+
+        if (external_pid != 0) {
+            external_pid_fallback_check_timer_file_descriptor = create_periodic_timer_file_descriptor_every_ms(1000);
+            if (external_pid_fallback_check_timer_file_descriptor == -1) {
+                const int timer_errno = errno;
+                fprintf_error("Failed to create periodic timer file descriptor for external pid fallback: %s\n",
+                              strerror(timer_errno));
+                goto run_wayland_idle_event_loop_cleanup;
+            }
+        }
+    }


Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

+    }
+
+    close_file_descriptor_if_open(&start_monitor_timer_file_descriptor, "start-monitor timer");
+    close_file_descriptor_if_open(&process_exit_wait_file_descriptor, "process-exit");
+    close_file_descriptor_if_open(&external_pid_fallback_check_timer_file_descriptor, "external-pid fallback timer");
+    if (verbose) {
+        fprintf(stderr, "Wayland connection lost or loop finished.\n");
+    }
+    return wait_for_pid_to_exit_checking_for_signals();


+    if (wayland_seat == NULL || wayland_idle_notifier == NULL) {
+        wl_registry_destroy(wayland_registry);
+        wayland_registry = NULL;
+        wl_display_disconnect(wayland_display);
+        wayland_display = NULL;
+        wayland_seat = NULL;
+        wayland_idle_notifier = NULL;
+        wayland_idle_notify_available = 0;
+        return 0;
+    }


+int start_wayland_idle_notification_object(
+    const struct ext_idle_notification_v1_listener *wayland_idle_notification_listener) {
+    if (wayland_idle_notification != NULL) {
+        return 0;
+    }
+    if (!wayland_idle_notify_available) {
+        return -1;
+    }
+
+    uint32_t timeout_ms_for_protocol = (user_idle_timeout_ms > UINT32_MAX)
+                                           ? UINT32_MAX
+                                           : (uint32_t) user_idle_timeout_ms;
+
+    if (wayland_idle_notifier_version >= 2) {
+        wayland_idle_notification = ext_idle_notifier_v1_get_input_idle_notification(
+            wayland_idle_notifier, timeout_ms_for_protocol, wayland_seat);
+    } else {
+        wayland_idle_notification = ext_idle_notifier_v1_get_idle_notification(
+            wayland_idle_notifier, timeout_ms_for_protocol, wayland_seat);
+    }
+
+    if (!wayland_idle_notification) {
+        return -1;
+    }
+
+    ext_idle_notification_v1_add_listener(wayland_idle_notification, wayland_idle_notification_listener, NULL);
+    wl_display_flush(wayland_display);
+    return 1;
+}


+        if (!found) {
+            found = 1;
+            best_numeric_suffix = (numeric_suffix >= 0) ? numeric_suffix : INT_MAX;
+            snprintf(best_name, sizeof(best_name), "%s", entry->d_name);
+            continue;
+        }
+
+        if (numeric_suffix >= 0 && numeric_suffix < best_numeric_suffix) {
+            best_numeric_suffix = numeric_suffix;
+            snprintf(best_name, sizeof(best_name), "%s", entry->d_name);
+            continue;
+        }
+
+        if (best_numeric_suffix == INT_MAX && numeric_suffix == -1) {
+            snprintf(best_name, sizeof(best_name), "%s", entry->d_name);
+        }
+    }


+        const char *digits = entry->d_name + 1;
+        if (*digits < '0' || *digits > '9') {
+            continue;
+        }
+
+        int display_number = (int)strtol(digits, NULL, 10);
+
+        char socket_path[PATH_MAX];
+        snprintf(socket_path, sizeof(socket_path), "%s/%s", x11_socket_dir, entry->d_name);
+
+        if (!file_is_socket(socket_path)) {
+            continue;
+        }


perk11 added 5 commits March 14, 2026 14:20

Experimental Wayland support

bfca456

Cron support

1ebbf94

Update README with Wayland

ff32f2b

Clarified Wayland support status and updated known issues section.

Move helper functions to separate files and remove cron process guess…

c95648f

… logic as it is not really needed

More cleanup

ff251c4

perk11 requested a review from Copilot March 15, 2026 19:13

Copilot started reviewing on behalf of perk11 March 15, 2026 19:13 View session

switch to constexpr

06a505d

Copilot AI reviewed Mar 15, 2026

View reviewed changes

Comment thread main.c Outdated

Comment thread main.c

Comment thread main.c

command_paused = 1;

}

}

}

Comment thread environment_guessing.h

Comment thread wayland.h

Comment thread main.c Outdated

perk11 added 9 commits March 15, 2026 16:36

Bring back deleted code

ee8053d

some error handling

6eaf37d

More error handling in wayland loop

d1c9183

Add const

8b6c385

cleanup useless comment

45349ad

Readme update

3d983b2

unused imports

6d0f732

Fix wayland_loop_result exit code

cf819c3

Add missing fclose in read_parent_process_id

82a209f

perk11 requested a review from Copilot May 30, 2026 02:38

Copilot started reviewing on behalf of perk11 May 30, 2026 02:38 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

perk11 and others added 9 commits May 29, 2026 21:42

Add missing includes in wayland.h

2ddfb70

add std gnu23

12ea9cd

Remove unnecessary import

674390c

Remove linker parameters from initial gcc calls

0bae990

Add exit_if_pid_has_finished() call

9c4c6de

format wayland.c

a0944f8

Potential fix for pull request finding

099ba89

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

5ce51ac

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

6117be7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix a bug in Wayland socket numeric suffix parsing where non-numeric…

c735a4f

… suffixes starting with a digit (e.g., `wayland-1abc`) were incorrectly accepted and parsed as numeric.

perk11 requested a review from Copilot May 30, 2026 03:13

Copilot started reviewing on behalf of perk11 May 30, 2026 03:13 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

Comment thread README.md Outdated

Comment thread environment_guessing.c Outdated

Comment thread wayland.c

Comment thread Makefile Outdated

Comment thread main.c

perk11 added 3 commits May 29, 2026 22:20

Remove duplicate exit_if_pid_has_finished

e55dd12

Switch to gnu17

629e5b1

Handle correctly when wayland_idle_notification is not available

c73d3a4

perk11 requested a review from Copilot May 30, 2026 15:08

Copilot started reviewing on behalf of perk11 May 30, 2026 15:08 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

Comment thread main.c

Comment thread main.c

Comment thread environment_guessing.c Outdated

Comment thread environment_guessing.c

Comment thread README.md Outdated

Comment thread process_handling.c Outdated

perk11 added 5 commits May 30, 2026 14:29

Add back the error message

9459d46

Update logging logic in environment_guessing.c

afc88f5

Update README

244cc9a

Fixed a potential path truncation issue in `build_xauthority_path_fro…

f50c502

…m_home_dir` where a long home directory path could lead to an incorrect `.Xauthority` path. README

Improve errors in wayland loop, rework duplicate code

bcbb239

perk11 requested a review from Copilot May 30, 2026 19:50

Copilot started reviewing on behalf of perk11 May 30, 2026 19:50 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

perk11 added 2 commits May 30, 2026 14:58

Use wait_for_pid_to_exit_checking_for_signals

042cf11

Restore old code

6bf4a11

perk11 changed the title ~~WIP Wayland support~~ Wayland support May 30, 2026

perk11 added 4 commits May 30, 2026 15:03

Update parameter

31e4312

README

ca7fdbb

Update path

264c0f8

code reuse

da10049

perk11 requested a review from Copilot May 30, 2026 20:10

Copilot started reviewing on behalf of perk11 May 30, 2026 20:10 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

Conversation

perk11 commented Mar 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants