fix: incorrect router hb_maps:get/3 Opts-as-fallback#705
Merged
samcamwilliams merged 1 commit intoedgefrom Mar 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following the
hb_maps:get/3default misuse checks (#701), i patched another one in dev_router (Neareststrategy path)issue
in
choose/5for<<"Nearest">>, this was usinghb_maps:get(<<"wallet">>, Node, Opts)- which means Opts was being passed as default -> confusing errors if missingpatched to explicit handling with arity 4 + fail fast:
also patched the same in
preprocess/3, at user path extraction^ it was
hb_maps:get(<<"path">>, Req, Opts)all tests pass
[done in 17.863 s] ======================================================= All 30 tests passed.