Skip to content

[ENHANCEMENT] Add support for sub-rows, fuzzy filtering and column filtering#90

Open
adrianSepiol wants to merge 8 commits intoperses:mainfrom
adrianSepiol:extend-table-component
Open

[ENHANCEMENT] Add support for sub-rows, fuzzy filtering and column filtering#90
adrianSepiol wants to merge 8 commits intoperses:mainfrom
adrianSepiol:extend-table-component

Conversation

@adrianSepiol
Copy link
Copy Markdown
Contributor

@adrianSepiol adrianSepiol commented Mar 17, 2026

Description

This change is needed to allow to implement folder structure for perses/perses#183. It introduces a way to filter table, filter visible column and a way to display tree-like structure.

Screenshots

Check perses/perses#183

In Table Plugin:

Screencast.from.07-04-26.14.34.05.webm

No toolbar:
Screenshot from 2026-04-07 14-39-37

With columns filter:
Screenshot from 2026-04-07 14-39-33

With search:
Screenshot from 2026-04-07 14-41-06

With Column filter and search:
Screenshot from 2026-04-07 14-39-27

Flamechart plugin:

No toolbar:

Screenshot from 2026-04-07 14-51-51

With columns filter:

Screenshot from 2026-04-07 14-51-36

With search:

Screenshot from 2026-04-07 14-52-03

With Column filter and search:

Screenshot from 2026-04-07 14-51-18

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Gladorme and others added 3 commits March 11, 2026 10:12
* [ENHANCEMENT] theme: add support for color-scheme

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* Add prop for enabling/disabling

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

---------

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
perses#89)

Bumps the gomod group with 1 update: [github.com/perses/perses](https://github.com/perses/perses).


Updates `github.com/perses/perses` from 0.53.0 to 0.53.1
- [Release notes](https://github.com/perses/perses/releases)
- [Changelog](https://github.com/perses/perses/blob/main/CHANGELOG.md)
- [Commits](perses/perses@v0.53.0...v0.53.1)

---
updated-dependencies:
- dependency-name: github.com/perses/perses
  dependency-version: 0.53.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gomod
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e component

Signed-off-by: Adrian Sepiół <adisepko@gmail.com>
Signed-off-by: Adrian Sepiół <adisepko@gmail.com>
@adrianSepiol adrianSepiol changed the title [ENHANCEMENT] Add support for sub-rows and expanded row model in tabl… [ENHANCEMENT] Add support for sub-rows, fuzzy filtering and column filtering Mar 25, 2026
Signed-off-by: Adrian Sepiół <adisepko@gmail.com>
@adrianSepiol adrianSepiol marked this pull request as ready for review March 25, 2026 10:03
@adrianSepiol adrianSepiol requested a review from a team as a code owner March 25, 2026 10:03
@shahrokni shahrokni self-requested a review March 30, 2026 15:52
@Nexucis
Copy link
Copy Markdown
Member

Nexucis commented Apr 1, 2026

shared package are more related to anything around plugins and component required to develop plugins.

Since folders are only here for the application itself, I believe these PR can be merged with the one in perses/perses. That will simplify the whole process also.

@Nexucis
Copy link
Copy Markdown
Member

Nexucis commented Apr 1, 2026

ah wait you are modifying the table as well. mmm @jgbernalp since the Table is widely used for the plugins, do you think these modifications are fine ?

@jgbernalp
Copy link
Copy Markdown
Contributor

Yes, this will be an improvement. We want to build a feature-rich table and re use it across the plugins.

But we need to make sure it works correctly with the plugins. @adrianSepiol can you attach some screenshots? I think we are adding a toolbar to the top of the table, but this might affect how tables are rendered in plugins. We can control this through a table options prop, so plugins can decide if they want to show the toolbar or not and by default will be disabled for backwards compatibility.

@adrianSepiol
Copy link
Copy Markdown
Contributor Author

Yes, this will be an improvement. We want to build a feature-rich table and re use it across the plugins.

But we need to make sure it works correctly with the plugins. @adrianSepiol can you attach some screenshots? I think we are adding a toolbar to the top of the table, but this might affect how tables are rendered in plugins. We can control this through a table options prop, so plugins can decide if they want to show the toolbar or not and by default will be disabled for backwards compatibility.

I've added screenshots for Table and Flamechart plugins, In both cases we would need some additional changes to make this look nicely. As you said this is by default disabled so it should not affect current look. For the Table plugin there is this mechanism that allows to filter values in each column, to be able to migrate to this toolbar I would probably need implement similar filtering on Table component level. I could try to add it here if you think this would also be useful.

@jgbernalp
Copy link
Copy Markdown
Contributor

I think we should minimize the changes on a single PR. The filtering is definitely useful, but maybe we should focus on the search and columns first. We already have a UX pattern for this, that might be useful. The search input fills the horizontal space and we have the columns icon at the end.

Screenshot 2026-04-07 at 15 16 14

I'll go further and remove the columns text as it might be redundant. WDYT?

cc @Gladorme @shahrokni

…tionality

Signed-off-by: Adrian Sepiół <adisepko@gmail.com>
# Conflicts:
#	components/package.json
#	package-lock.json
Signed-off-by: Adrian Sepiół <adisepko@gmail.com>
@adrianSepiol
Copy link
Copy Markdown
Contributor Author

I think we should minimize the changes on a single PR. The filtering is definitely useful, but maybe we should focus on the search and columns first. We already have a UX pattern for this, that might be useful. The search input fills the horizontal space and we have the columns icon at the end.
Screenshot 2026-04-07 at 15 16 14

I'll go further and remove the columns text as it might be redundant. WDYT?

cc @Gladorme @shahrokni
I've updated the look. Let me know what you think.

Screenshot from 2026-04-08 12-44-14 Screenshot from 2026-04-08 12-43-12 Screenshot from 2026-04-08 12-42-14 Screenshot from 2026-04-08 12-42-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants