Add "Set column width to maximum/minimum" actions#148
Open
jinliu wants to merge 1 commit intopeterfajdiga:masterfrom
Open
Add "Set column width to maximum/minimum" actions#148jinliu wants to merge 1 commit intopeterfajdiga:masterfrom
jinliu wants to merge 1 commit intopeterfajdiga:masterfrom
Conversation
Owner
peterfajdiga
left a comment
peterfajdiga
left a comment
There was a problem hiding this comment.
This is a nice feature, thanks!
column.minWidth() can be too small to be useful. That's why I'm thinking if maybe instead of using column.minWidth() and column.maxWidth, we should use min(config.presetWidths) and max(config.presetWidths). Help me decide. What do you think?
| }, | ||
| { | ||
| name: "column-width-maximize", | ||
| description: "Set column width to maximum", |
Owner
There was a problem hiding this comment.
Suggested change
| description: "Set column width to maximum", | |
| description: "Increase column width to maximum", |
This will make sure it's next to column-width-increase in the shortcuts list.
| }, | ||
| { | ||
| name: "column-width-minimize", | ||
| description: "Set column width to minimum", |
Owner
There was a problem hiding this comment.
Suggested change
| description: "Set column width to minimum", | |
| description: "Decrease column width to minimum", |
This will make sure it's next to column-width-decrease in the shortcuts list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.