Skip to content

Conversation

@disk91
Copy link

@disk91 disk91 commented Dec 22, 2014

BeagleBone gpio integration

BeagleBone gpio integration
@pfalcon
Copy link
Owner

pfalcon commented Dec 22, 2014

Thanks for this pull request. There's one problem though - it's licensing doesn't match main codebase licensing (your code GPLv3, main codebase BSD). I personally value GPL and think that it should be the license for the toolsets, but at the same time, I value original author(s)' selection of license and think it's a good courtesy to them to not change it on a whim. That's my thoughts about it, I'm open to other opinions/arguments.

@disk91
Copy link
Author

disk91 commented Dec 23, 2014

Sure no problem to move it to bsd, i do not care when adfing the header. I'll change it to bsd.
Paul

Le 22 déc. 2014 à 21:35, Paul Sokolovsky notifications@github.com a écrit :

Thanks for this pull request. There's one problem though - it's licensing doesn't match main codebase licensing (your code GPLv3, main codebase BSD). I personally value GPL and think that it should be the license for the toolsets, but at the same time, I value original author(s)' selection of license and think it's a good courtesy to them to not change it on a whim. That's my thoughts about it, I'm open to other opinions/arguments.


Reply to this email directly or view it on GitHub.

@disk91
Copy link
Author

disk91 commented Jan 6, 2015

License back to BSD, I'm not yet really familiar with pull reqest. Hope it works like this. Tell me if it is ok.

@pfalcon
Copy link
Owner

pfalcon commented Jan 6, 2015

Thanks for coming back to this!

Indeed, there were some tricky changes in these latest commits - like inconsistent tab vs spaces. I took freedom to run them thru "expand" command. I also put back your explicit copyright (c) - that's surely ok, as you're the author of that code. I also renamed both files to give a better hint how they different from each other. I also squashed all these changes to a single commit which is here: e942fb0 . Let me know if it's ok by you. Note that no code changes were done - only whitespace and "metadata".

@disk91
Copy link
Author

disk91 commented Jan 7, 2015

Sounds perfect to me ;)
Paul

Le 6 janv. 2015 à 22:32, Paul Sokolovsky notifications@github.com a écrit :

Thanks for coming back to this!

Indeed, there were some tricky changes in these latest commits - like inconsistent tab vs spaces. I took freedom to run them thru "expand" command. I also put back your explicit copyright (c) - that's surely ok, as you're the author of that code. I also renamed both files to give a better hint how they different from each other. I also squashed all these changes to a single commit which is here: e942fb0 . Let me know if it's ok by you. Note that no code changes were done - only whitespace and "metadata".


Reply to this email directly or view it on GitHub.

@disk91
Copy link
Author

disk91 commented Jan 25, 2015

I just add the RaspberryPi integration, It works really faster than BeagleBone and should be more frequent. If you can merge it would be perfect:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants