Skip to content

fix: remove db_owner requirement for allow_writes on MCP #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsivaprasad merged 1 commit into from
May 4, 2026
+1 −11
Merged

fix: remove db_owner requirement for allow_writes on MCP #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions server/internal/api/apiv1/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,15 +414,6 @@ func validateConnectAs(svc *api.ServiceSpec, dbUsers []*api.DatabaseUserSpec, pa

for _, u := range dbUsers {
if u.Username == svc.ConnectAs {
// For MCP with allow_writes, the connect_as user must be the db owner
if svc.ServiceType == "mcp" {
if allowWrites, ok := svc.Config["allow_writes"].(bool); ok && allowWrites {
if u.DbOwner == nil || !*u.DbOwner {
err := errors.New("allow_writes requires connect_as to reference a database_users entry with db_owner: true")
return []error{newValidationError(err, connectAsPath)}
}
}
}
return nil
}
}
Expand Down
3 changes: 1 addition & 2 deletions server/internal/api/apiv1/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,8 +2100,7 @@ func TestValidateConnectAs(t *testing.T) {

t.Run("non-owner with allow_writes", func(t *testing.T) {
errs := validateConnectAs(baseSvc("app_read_only", true), dbUsers, nil)
assert.Len(t, errs, 1)
assert.ErrorContains(t, errs[0], "allow_writes requires connect_as to reference a database_users entry with db_owner: true")
assert.Empty(t, errs)
})

t.Run("empty connect_as", func(t *testing.T) {
Expand Down