Skip to content

Fixed an issue where the default fillfactor value for B-tree indexes was incorrect. #9648 #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pravesh-sharma wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −9
Open

Fixed an issue where the default fillfactor value for B-tree indexes was incorrect. #9648 #9653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7199967
Fixed an issue where the default fillfactor value for B-tree indexes …
pravesh-sharma Feb 20, 2026
7549f7c
Fixed review comments
pravesh-sharma Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/servers/databases/schemas/tables/indexes/tests/11_plus/create_btree_desc_null_first.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
ON public.test_table_for_indexes USING btree
(id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
INCLUDE(name, id)
WITH (fillfactor=100)
WITH (fillfactor=90)
TABLESPACE pg_default;
2 changes: 1 addition & 1 deletion ...servers/databases/schemas/tables/indexes/tests/13_plus/alter_reset_fillfactor_cluster.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
ON public.test_table_for_indexes USING btree
(id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
INCLUDE(name, id)
WITH (fillfactor=100, deduplicate_items=True)
WITH (fillfactor=90, deduplicate_items=True)
TABLESPACE pg_default;

COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"
Expand Down
2 changes: 1 addition & 1 deletion ...s/servers/databases/schemas/tables/indexes/tests/13_plus/create_btree_desc_null_first.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
ON public.test_table_for_indexes USING btree
(id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
INCLUDE(name, id)
WITH (fillfactor=100, deduplicate_items=True)
WITH (fillfactor=90, deduplicate_items=True)
TABLESPACE pg_default;
2 changes: 1 addition & 1 deletion ...servers/databases/schemas/tables/indexes/tests/15_plus/alter_reset_fillfactor_cluster.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
(id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
INCLUDE(name, id)
NULLS NOT DISTINCT
WITH (fillfactor=100, deduplicate_items=True)
WITH (fillfactor=90, deduplicate_items=True)
TABLESPACE pg_default;

COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"
Expand Down
2 changes: 1 addition & 1 deletion ...s/servers/databases/schemas/tables/indexes/tests/15_plus/create_btree_desc_null_first.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
(id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
INCLUDE(name, id)
NULLS NOT DISTINCT
WITH (fillfactor=100, deduplicate_items=True)
WITH (fillfactor=90, deduplicate_items=True)
TABLESPACE pg_default;
1 change: 1 addition & 0 deletions ...erver_groups/servers/databases/schemas/tables/indexes/tests/default/create_hash_index.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
CREATE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
ON public.test_table_for_indexes USING hash
(id)
WITH (fillfactor=75)
TABLESPACE pg_default;
6 changes: 4 additions & 2 deletions ...rver_groups/servers/databases/schemas/tables/templates/indexes/sql/11_plus/properties.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@ SELECT DISTINCT ON (cls.relname)
COALESCE(
substring(array_to_string(cls.reloptions, ',') FROM 'fillfactor=([0-9]*)')::int,
CASE am.amname
WHEN 'btree' THEN 100
WHEN 'gist' THEN 90
WHEN 'btree' THEN 90
WHEN 'gist' THEN 90
WHEN 'hash' THEN 75
WHEN 'spgist' THEN 90
ELSE NULL
END
) AS fillfactor,
Expand Down
4 changes: 3 additions & 1 deletion ...rver_groups/servers/databases/schemas/tables/templates/indexes/sql/13_plus/properties.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ SELECT DISTINCT ON (cls.relname)
COALESCE(
substring(array_to_string(cls.reloptions, ',') FROM 'fillfactor=([0-9]*)')::int,
CASE am.amname
WHEN 'btree' THEN 100
WHEN 'btree' THEN 90
WHEN 'gist' THEN 90
WHEN 'hash' THEN 75
WHEN 'spgist' THEN 90
ELSE NULL
END
) AS fillfactor,
Expand Down
4 changes: 3 additions & 1 deletion ...rver_groups/servers/databases/schemas/tables/templates/indexes/sql/15_plus/properties.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ SELECT DISTINCT ON (cls.relname)
COALESCE(
substring(array_to_string(cls.reloptions, ',') FROM 'fillfactor=([0-9]*)')::int,
CASE am.amname
WHEN 'btree' THEN 100
WHEN 'btree' THEN 90
WHEN 'gist' THEN 90
WHEN 'hash' THEN 75
WHEN 'spgist' THEN 90
ELSE NULL
END
) AS fillfactor,
Expand Down
Loading