fix: add missing verify=VERIFY_SSL to network requests#19
Open
fix: add missing verify=VERIFY_SSL to network requests#19
Conversation
fetch_app_key and fetch_wrapped_key_share were missing the verify=VERIFY_SSL parameter on their requests.get() calls, making them inconsistent with all other HTTP calls in the file and causing SSL failures with self-signed certificates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_app_keyandfetch_wrapped_key_shareinnetwork.pywere missingverify=VERIFY_SSLon theirrequests.get()callsTest plan