Skip to content

Live Preview Edit Polishing #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
devvaannsh wants to merge 120 commits into
base: main
Choose a base branch
from
Open

Live Preview Edit Polishing #2490

devvaannsh wants to merge 120 commits into from
+3,935 −1,603

Conversation

@devvaannsh
Copy link
Member

@devvaannsh devvaannsh commented Nov 24, 2025

No description provided.

@devvaannsh
feat: prevent user elements like links and buttons from handling the …
3c39f49 
…click
@devvaannsh
fix: internal blocker also blocking in preview mode
9e3478b
@devvaannsh
fix: cursor not getting positioned properly on element click in edit …
e5e24b1 
…mode
@devvaannsh
feat: check and clear any selection if anything exists before selecti…
15a8768 
…ng a new element
@devvaannsh
refactor: use better style when image gallery svg is selected
0785315
@devvaannsh
feat: show pre-filled folder in image folder dialog
d80ea2b
@devvaannsh
fix: root directories not being displayed when user clears a pre fill…
4abb404 
…ed input
@devvaannsh
fix: drag drop not working because mouse down is blocked
8499926
@devvaannsh
refactor: improve suggestions list colors to match it with tab bar
208226e
@devvaannsh
fix: tests failing as boxes not getting dismissed on click on body or…
3653700 
… html tag
@devvaannsh
feat: show a toast message when folder selection dialog is open
79b260a
@devvaannsh
refactor: better UI for the toast message
d51696f
@devvaannsh
fix: localize the dialog overlay string
86c11f2
@devvaannsh
fix: use higher z-index so that overlay does not get hidden
9b18baf
@devvaannsh
fix: window focus handlers are never cleared which was causing repeti…
79c305a 
…tive calls on same element
@devvaannsh
feat: add cut copy paste buttons in options box
db16740
@devvaannsh
refactor: move the edit options inside a dropdown
c1877c7
@devvaannsh
feat: localize the strings used in the dropdown
fb08a2b
@devvaannsh
refactor: make dropdown consistent to existing phoenix colors
dc05338
@devvaannsh
fix: dropdown not getting dismissed on other element click
c714d96
@devvaannsh
refactor: use font awesome icons for cut copy paste
e7ec0e5
@devvaannsh
fix: improvised positioning of the dropdown
e76b50c
@devvaannsh
feat: add ruler lines feature when element is clicked
3537382
@devvaannsh
fix: ruler lines not getting updated unless when clicked element changes
2b9a071
@devvaannsh
feat: ruler lines and outline to be shown in blue for non-editable el…
ec2ae2c 
…ements
@devvaannsh
refactor: use rgba vals with opacity to ruler lines to make it less d…
37c1261 
…istracting
abose and others added 29 commits December 7, 2025 12:15
@abose
refactor: infobox and ruler styles in remote functions
91c9fa8
@abose
refactor: toast message and dialog overlay styles
1f741a8
@abose
refactor: ai prompt box css in remote functions
41c15c2
@abose
refactor: image gallery css in remote functions
ac96446
@abose
refactor: hyperlink editor and hot corner css in remote functions
d2d332f
@abose
fix: prod build doesnt inject live preview styles are replace comment…
ffa472b 
…s stripped by build
@devvaannsh
fix: improved drag drop
2c311a2
@devvaannsh
Revert "fix: improved drag drop"
e0b1150 
This reverts commit 2c311a2.
@devvaannsh
feat: show drop marker label with tag class id names
ece11d0
@devvaannsh
refactor: make label styles consistent to other internal elements
4824d0c
@abose
chore: inlining json files as well for require
81a970b
@abose
build: concantenate js relative files as well
b3b1b60
@devvaannsh
feat: show a outline over the target element
3fdf721
@devvaannsh
fix: also add left side check overflow for the label
210c2e6
@devvaannsh
feat: reliable dragging using a cycle marker for all possible drop po…
242feb7 
…ints
@abose
build: failed if any phoenix pro files are not inlineable
3b3eae1
@abose
chore: remove source map generation as it never worked and we dont ob…
636399d 
…fuscate anyway
@abose
build: remove pro sources from built artifacts after dist generation
866b72a
@abose
chore: event listener attachment decisions taken in live preview with…
0face1b 
…out message passing
@devvaannsh
fix: replace the cycling logic with the divide total space by number …
972e3f6 
…of candidates logic
@devvaannsh
fix: drop markers not getting cleared on auto scroll
70b7f15
@devvaannsh
fix: hot corners not working
02a1e11
@devvaannsh
fix: improve hot corner styles
f1d0acb
@abose
refactor: remove highlight flag as we use mode now for preview, edit …
bdb8476 
…and hilight
@devvaannsh
fix: ruler lines and boxes overlapping hot corners
a27b650
@abose
refactor: remove remote styles config passing as it can be passed dir…
98f5e2a 
…ectly in code
@abose
fix: test runner showing stray buttons due to hot corners
bbc9205
@abose
fix: leaky listeners/event handlers in live document
c5670f3 
also removed a reset function that doesnt seem to be userd rather than when thne live preview page
was loaded, and at load time, the page is resetted/has no state anyway
@abose
refactor: move dismissLivePreviewEditBoxes into pro extension
138313c
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 10, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devvaannsh @abose