Skip to content

Better & non-distracting live preview highlighting #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 35 commits into from
Mar 20, 2026
+750 −450

fix: live preview highlight mode tests failing

752fee4
Select commit
Loading
Failed to load commit list.
Merged

Better & non-distracting live preview highlighting #2706

fix: live preview highlight mode tests failing
752fee4
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 19, 2026 in 39s

Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 825 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzb-Ezjd1orA-MjPBjL&open=AZzb-Ezjd1orA-MjPBjL&pullRequest=2706

Check warning on line 273 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1Ge&open=AZyJ-zA9IPT-dly1h1Ge&pullRequest=2706

Check warning on line 807 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function 'redrawUIBoxes' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzb-Ezjd1orA-MjPBjK&open=AZzb-Ezjd1orA-MjPBjK&pullRequest=2706

Check warning on line 324 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzomrS4vWdbsfLw89m3&open=AZzomrS4vWdbsfLw89m3&pullRequest=2706

Check warning on line 353 in src/extensionsIntegrated/Phoenix-live-preview/main.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZy1Ca47voVWQ2TYI4mg&open=AZy1Ca47voVWQ2TYI4mg&pullRequest=2706

Check failure on line 1026 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 53 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzE7nidAcnzKZukzkhI&open=AZzE7nidAcnzKZukzkhI&pullRequest=2706

Check warning on line 322 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1Gq&open=AZyJ-zA9IPT-dly1h1Gq&pullRequest=2706

Check warning on line 1187 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzE7nidAcnzKZukzkhK&open=AZzE7nidAcnzKZukzkhK&pullRequest=2706

Check warning on line 287 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1Gf&open=AZyJ-zA9IPT-dly1h1Gf&pullRequest=2706

Check warning on line 1425 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyVpo6KHrekD60xYUnj&open=AZyVpo6KHrekD60xYUnj&pullRequest=2706

Check warning on line 1280 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function '_getTreePath' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzE7nidAcnzKZukzkhM&open=AZzE7nidAcnzKZukzkhM&pullRequest=2706

Check warning on line 116 in src/extensionsIntegrated/Phoenix-live-preview/live-preview.css

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Text does not meet the minimal contrast requirement with its background. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZymGiDoeQUfltL-kPkr&open=AZymGiDoeQUfltL-kPkr&pullRequest=2706

Check warning on line 1283 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzE7nidAcnzKZukzkhN&open=AZzE7nidAcnzKZukzkhN&pullRequest=2706

Check warning on line 319 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzomrS4vWdbsfLw89m2&open=AZzomrS4vWdbsfLw89m2&pullRequest=2706

Check failure on line 545 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `getAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZy1Ca-AvoVWQ2TYI4mk&open=AZy1Ca-AvoVWQ2TYI4mk&pullRequest=2706

Check warning on line 318 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzomrS4vWdbsfLw89m1&open=AZzomrS4vWdbsfLw89m1&pullRequest=2706

Check warning on line 751 in src/LiveDevelopment/LiveDevMultiBrowser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzmYlIflpXvOsy3Axey&open=AZzmYlIflpXvOsy3Axey&pullRequest=2706

Check warning on line 420 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzomrS4vWdbsfLw89m7&open=AZzomrS4vWdbsfLw89m7&pullRequest=2706

Check warning on line 683 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1G2&open=AZyJ-zA9IPT-dly1h1G2&pullRequest=2706

Check warning on line 542 in src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZy1Ca-AvoVWQ2TYI4mh&open=AZy1Ca-AvoVWQ2TYI4mh&pullRequest=2706

Check failure on line 1713 in src/language/CSSUtils.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZzoxtwI9A8E2e9CZM-L&open=AZzoxtwI9A8E2e9CZM-L&pullRequest=2706

Check warning on line 313 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1Gi&open=AZyJ-zA9IPT-dly1h1Gi&pullRequest=2706

Check warning on line 1239 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZypeqx5sZaVqOVfxMy_&open=AZypeqx5sZaVqOVfxMy_&pullRequest=2706

Check warning on line 303 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1Gg&open=AZyJ-zA9IPT-dly1h1Gg&pullRequest=2706

Check warning on line 323 in src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZyJ-zA9IPT-dly1h1Gr&open=AZyJ-zA9IPT-dly1h1Gr&pullRequest=2706
View more details on SonarQubeCloud