Skip to content

Fix Elixir 1.20 compilation warnings #6687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gilbertwong96 wants to merge 1 commit into from
+3 −1
Closed

Fix Elixir 1.20 compilation warnings #6687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
elixir 1.20.0-rc.6
erlang 27.3.3
2 changes: 1 addition & 1 deletion lib/phoenix/naming.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
def unsuffix(value, suffix) do
string = to_string(value)
suffix_size = byte_size(suffix)
prefix_size = byte_size(string) - suffix_size

Check warning on line 44 in lib/phoenix/naming.ex

View workflow job for this annotation

GitHub Actions / mix test (OTP 25.3.2.9 | Elixir 1.15.8) 

variable "prefix_size" is unused (if the variable is not meant to be used, prefix it with an underscore)
case string do
<<prefix::binary-size(^prefix_size), ^suffix::binary>> -> prefix
<<prefix::binary-^size(prefix_size), ^suffix::binary>> -> prefix
_ -> string
end
end
Expand Down
Loading