Added new function to edit events#76
Open
HenrikEngen wants to merge 4 commits intofeature/createEventfrom
Open
Added new function to edit events#76HenrikEngen wants to merge 4 commits intofeature/createEventfrom
HenrikEngen wants to merge 4 commits intofeature/createEventfrom
Conversation
petterroea
reviewed
Feb 8, 2026
| 'data': error | ||
| } | ||
|
|
||
| if update_name is True: context.eventInstance.name = request.json_body['name'] |
Contributor
There was a problem hiding this comment.
We don't need these oneliners, so please have normal if sentences where the code to be executed is on the next line
petterroea
reviewed
Feb 8, 2026
Contributor
petterroea
left a comment
petterroea
left a comment
There was a problem hiding this comment.
More tests, and some formatting stuff, otherwise good.
| assert privileged_entry.json_body['uuid'] != None No newline at end of file | ||
| assert privileged_entry.json_body['uuid'] != None | ||
|
|
||
| def test_edit_event(testapp, upcoming_event): |
Contributor
There was a problem hiding this comment.
I would like tests that verify that the editing works as well. That is, edit each field and verify that the field was actually edited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this pull request
This pull request will add functionality to edit events
Dependencies:
Required because this pull request has the new create_event code