subscription: use const Method + some refactoring#16
Open
tzzed wants to merge 1 commit intophoops:masterfrom
Open
subscription: use const Method + some refactoring#16tzzed wants to merge 1 commit intophoops:masterfrom
tzzed wants to merge 1 commit intophoops:masterfrom
Conversation
zarelit
reviewed
Jul 12, 2022
| r.Body = http.MaxBytesReader(w, r.Body, 8*1024*1024) | ||
|
|
||
| decoder := json.NewDecoder(r.Body) | ||
| r.Body = http.MaxBytesReader(w, r.Body, 8<<20) |
Member
There was a problem hiding this comment.
What is the purpose of using the bitwise operation instead of the numeric multiplication?
Contributor
Author
There was a problem hiding this comment.
I my opinion it is better to use bit shifting for multiplication of power of two, even if finally is the same result but I think we should use a const for readability. What do you think about it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use const MethodPost + some refactoring.