Prevent instantiation and cloning of __PHP_Incomplete_Class#21325
Open
jordikroon wants to merge 5 commits intophp:masterfrom
Open
Prevent instantiation and cloning of __PHP_Incomplete_Class#21325jordikroon wants to merge 5 commits intophp:masterfrom
jordikroon wants to merge 5 commits intophp:masterfrom
Conversation
ndossche
reviewed
Mar 1, 2026
Member
|
I believe an RFC discussion is mandatory. I don't necessarily think it's a bad BC break, but the benefit is questionable. |
jordikroon
force-pushed
the
incomplete_class-constructor
branch
from
926b6df to
6ef203a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though technically this could cause a BC break I don't think this is a real dealbreaker since by logic it should not be possible.
Extending or using newInstanceWithoutConstructor already wasn't possible. This PR extends that by disallowing calling the constructor or cloning
__PHP_Incomplete_Class.If someone thinks this BC will cause real problems. I am okay with creating an RFC instead backing this PR.
There were a few tests relying on
new __PHP_Incomplete_Class, those have been updated to reflect the change.