Require using local storage provider

[iMattPro]

@rubencm Trying this approach here instead. Only allow icon management if the storage provider for Web App Icons is set to Local.

So with these settings:

You can do:

Otherwise, we say no and why not:

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e9540c) to head (62b0f2b).

Additional details and impacted files

@@             Coverage Diff             @@
##                main       #33   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        84        87    +3     
===========================================
  Files              8         8           
  Lines            305       314    +9     
===========================================
+ Hits             305       314    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rubencm]

👍

I think it should be only for resync, the upload is ok

[iMattPro]

👍

I think it should be only for resync, the upload is ok

I'm not sure if I want these files being served from anything other than local disk. I tried to use your DB adapter extension. It was broken, so I fixed the issues but still can't use it. Something about the system still wants to validate paths even though the DB doesn't have a path field. Otherwise I would have tested if files from another provider would even work for my purposes here. Because if they could work, then yeah this would only need to apply to the resync method.

[rubencm]

If you want to use files only in local, then maybe should not use storage, and the filespec classes should not be deprecated, not sure
But i think you can and should use it better

[iMattPro]

I've put too much work and time into switching away from the deprecated class to go back. 🤭

[rubencm]

You can use storage, but for loading the icons you will need to use the storage controller

[iMattPro]

I will implement the storage controller after the core implements stateless routes as seen here phpbb/phpbb@master...marc1706:phpbb:feature/stateless_sessions

Also the storage system will need to implement stateless routing as well by changing, for example:

phpbb_storage_avatar:
    path:             /avatar/{file}
    defaults:
        _controller:  storage.controller.avatar:handle

to

phpbb_storage_avatar:
    path:             /avatar/{file}
    defaults:
        _controller:  storage.controller.avatar:handle
    stateless: true

[rxu]

There should be a way to restrict adapter options to only local one and to prevent changing adapter for the pwakit.storage in the backend. Core events could be added if needed.

[iMattPro]

There should be a way to restrict adapter options to only local one and to prevent changing adapter for the pwakit.storage in the backend. Core events could be added if needed.

I was going to say the same thing. There should be a method in the main storage class perhaps, to have something like allowed providers? So we can do stuff like:

set_allowed_providers(['local']);

[rubencm]

I was thinking in something like this if is possible to disable configure it from acp

    phpbb.pwakit.storage:
        class: phpbb\pwakit\storage\storage
        arguments:
            - '@dbal.conn'
            - '@cache.driver'
            - '@storage.adapter.factory'
            - 'phpbb_pwakit'
            - '%tables.storage%'
        tags:
            - { name: storage }
        editable: false

[iMattPro]

That would be cool too, but only if it prevents editing of the adapter/provider thingy. being able to change the path is still very useful to let admins do.

[rubencm]

That would be cool too, but only if it prevents editing of the adapter/provider thingy. being able to change the path is still very useful to let admins do.

One option to allow to update the adapter/provider and other to update the options or something like that

[iMattPro]

👍🏻

…

On Jan 21, 2025 at 8:11 AM -0800, Ruben ***@***.***>, wrote: > That would be cool too, but only if it prevents editing of the adapter/provider thingy. being able to change the path is still very useful to let admins do. One option to allow to update the adapter/provider and other to update the options or something like that — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[iMattPro]

I was thinking in something like this if is possible to disable configure it from acp

    phpbb.pwakit.storage:
        class: phpbb\pwakit\storage\storage
        arguments:
            - '@dbal.conn'
            - '@cache.driver'
            - '@storage.adapter.factory'
            - 'phpbb_pwakit'
            - '%tables.storage%'
        tags:
            - { name: storage }
        editable: false

An option might be to use method calls:

    phpbb.pwakit.storage:
        class: phpbb\pwakit\storage\storage
        arguments:
            - '@dbal.conn'
            - '@cache.driver'
            - '@storage.adapter.factory'
            - 'phpbb_pwakit'
            - '%tables.storage%'
        tags:
            - { name: storage }
        calls:
            - [allowed_providers, ['@storage.provider.local']]
            - [set_options, []]

But then of course in the storage classes you'd need allowed_providers() and set_options() methods.