Don't add too many spaces when replacing clauses#558
Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom Aug 25, 2024
Merged
Don't add too many spaces when replacing clauses#558MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Conversation
MoonE
force-pushed
the
replace-clause-spaces
branch
from
782034f to
75679ca
Compare
williamdes
reviewed
May 9, 2024
MoonE
force-pushed
the
replace-clause-spaces
branch
3 times, most recently
from
4945c8f to
18c70f3
Compare
williamdes
approved these changes
May 9, 2024
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
Nice, this version is probably better because I see quite some crash reports due to ram eaten while trying to compile a regex
Member
|
I think this should target the |
MoonE
force-pushed
the
replace-clause-spaces
branch
from
18c70f3 to
bfc38a3
Compare
When a clause is removed (replaced with empty string) or the replacement string already has spaces or the replacement was at the start or end of the statement there were unnecessary spaced included in the statement. Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
MoonE
force-pushed
the
replace-clause-spaces
branch
from
bfc38a3 to
b1764f1
Compare
williamdes
approved these changes
Jun 3, 2024
MauricioFauth
approved these changes
Aug 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were unnecessary spaced included in the statement when
This will require some tests to be updated in phpMyAdmin.
e. g.: https://github.com/phpmyadmin/phpmyadmin/blob/99c2939eda6c1c3ab9ffe4b1f903bab182d686db/test/classes/Display/ResultsTest.php#L1469