Add support for psalm-inheritors and phpstan-sealed tag#273
Add support for psalm-inheritors and phpstan-sealed tag#273ondrejmirtes merged 4 commits intophpstan:2.1.xfrom
psalm-inheritors and phpstan-sealed tag#273Conversation
|
I’d prefer a different name for the PHPStan tag. some keywords to consider:
What are your suggestions? |
|
I checked all the possibility and psalm supports them
Since it works for So I would say something like
But if we look at other languages (and the related php rfc https://wiki.php.net/rfc/sealed_classes), seems adding a
Therefor maybe something like Or Does anything satisfy you @ondrejmirtes ? |
|
|
|
Of course Phpstan should understand psalm inheritors too. |
psalm-inheritors and phpstan-inheritors tagpsalm-inheritors and phpstan-sealed tag
Done with |
|
The is failing because of php deprecation on PHPUnit 10.5.11. The dev-dependency was bumped on slevomat coding standard in commit 4747e312a24d4827b1d090b5908c7d5b16cf0580 |
|
@VincentLanglet Yes, in a separate PR please. |
|
Thank you! Please send a PR to phpstan-src as well. |
Needed to implements the following feature on phpstan side
https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-inheritors