Skip to content

ExpressionTypeHolder: re-use objects more often #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 2 commits into from
Jan 22, 2026
Merged

ExpressionTypeHolder: re-use objects more often #4801

ondrejmirtes merged 2 commits into from
Jan 22, 2026
+9 −6

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Jan 22, 2026

php bin/phpstan analyse src/Analyser/ src/Rules/ -v --debug

before this PR:

Elapsed time: 28.18 seconds
Used memory: 443.66 MB

after this PR:

Elapsed time: 28.09 seconds
Used memory: 434.81 MB

=> saves 9 MB memory

@ondrejmirtes ondrejmirtes merged commit d532879 into phpstan:2.1.x Jan 22, 2026
631 of 638 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Jan 22, 2026

Thank you!

@staabm staabm deleted the fast-expt branch January 22, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @ondrejmirtes