Fix closure type inference in FiberScope #4807
Open
+188
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnutix
force-pushed
the
fix/fiberscope-closure-type-inference
branch
4 times, most recently
from
e13aa2a to
d9c9179
Compare
FiberScope::pushInFunctionCall() and popInFunctionCall() were no-ops, which prevented the inFunctionCallsStack from being populated when using FNSR (Fiber Node Scope Resolver). This caused closure parameter types to not be properly inferred from the expected callable type when a closure is passed as an argument. The fix implements proper function call stack tracking in FiberScope and removes the FiberScope exclusion in ParametersAcceptorSelector. Fixes #13993 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
gnutix
force-pushed
the
fix/fiberscope-closure-type-inference
branch
from
d9c9179 to
ef0221a
Compare
The test uses PHP 8.1+ features (Fibers) and tests FiberScope-specific behavior. Add // lint >= 8.1 comment to skip the test on PHP 7.4 and 8.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code regarding issue phpstan/phpstan#13993
Summary
FiberScope::pushInFunctionCall()andpopInFunctionCall()which were no-ops, preventing closure parameter types from being properly inferredFiberScopeexclusion inParametersAcceptorSelector::selectFromArgs()sinceFiberScopenow properly handles function call trackingProblem
When using FNSR (Fiber Node Scope Resolver, enabled by default on PHP 8.1+), closure parameter types were not being properly inferred from the expected callable type. This caused false positives like:
The root cause was that
FiberScope::pushInFunctionCall()was a no-op (just returning$this), so theinFunctionCallsStackwas never populated. This stack is used bygetClosureType()to access the expected callable signature and properly infer closure parameter types.Test plan
NodeScopeResolverTesttests passTestClosureTypeRuleTestpasses