Skip to content

ConstantArrayType: prevent unnecessary work #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
staabm wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
+3 −1
Open

ConstantArrayType: prevent unnecessary work #4811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5a3839
ConstantArrayType: prevent unnecessary work
staabm Jan 23, 2026
6a007a2
simplify
staabm Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Type/Constant/ConstantArrayType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,9 +563,11 @@
if (
$has->yes()
&& !$phpVersion->supportsCallableInstanceMethods()
&& $classOrObject->isString()->yes()

Check warning on line 566 in src/Type/Constant/ConstantArrayType.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.3, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 			if (
 				$has->yes()
 				&& !$phpVersion->supportsCallableInstanceMethods()
-				&& $classOrObject->isString()->yes()
+				&& !$classOrObject->isString()->no()
 			) {
 				$methodReflection = $type->getMethod($methodName->getValue(), new OutOfClassScope());

Check warning on line 566 in src/Type/Constant/ConstantArrayType.php

View workflow job for this annotation

GitHub Actions / Mutation Testing (8.4, ubuntu-latest) 

Escaped Mutant for Mutator "PHPStan\Infection\TrinaryLogicMutator":

@@ @@
 			if (
 				$has->yes()
 				&& !$phpVersion->supportsCallableInstanceMethods()
-				&& $classOrObject->isString()->yes()
+				&& !$classOrObject->isString()->no()
 			) {
 				$methodReflection = $type->getMethod($methodName->getValue(), new OutOfClassScope());
) {
$methodReflection = $type->getMethod($methodName->getValue(), new OutOfClassScope());
if ($classOrObject->isString()->yes() && !$methodReflection->isStatic()) {

if (!$methodReflection->isStatic()) {
continue;
}
}
Expand Down
Loading