Merged
Conversation
staabm
reviewed
Apr 4, 2026
Contributor
staabm
left a comment
staabm
left a comment
There was a problem hiding this comment.
Can we come up with a test showing a missing tip?
Contributor
Author
This will be in another PR, here I don't add the tip yet and just improve the perf with a fast check |
staabm
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #5394 I found this
Also, this helper rely a lot on IsSuperTypeOf result but then transform checks into boolean and lose the reason.
I feel like it would be great to keep the reasons to add them as tips of the errors.