Skip to content

Fix phpstan/phpstan#14063: Readonly property modification through clone() is not reported outside allowed scope #5432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phpstan-bot wants to merge 3 commits into
base: 2.1.x
Choose a base branch
from
+58 −0
Open

Fix phpstan/phpstan#14063: Readonly property modification through clone() is not reported outside allowed scope #5432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac40a6f
Add regression test for readonly class property modification via clone()
VincentLanglet Apr 8, 2026
60538da
Remove unnecessary bug-14063 test from ReadOnlyPropertyAssignRuleTest
phpstan-bot Apr 8, 2026
90137ed
Fix invalid test: non-readonly class cannot extend readonly class
phpstan-bot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/PHPStan/Rules/Properties/AccessPropertiesInAssignRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,25 @@ public function testBug13123(): void
$this->analyse([__DIR__ . '/data/bug-13123.php'], []);
}

#[RequiresPhp('>= 8.5')]
public function testBug14063(): void
{
$this->analyse([__DIR__ . '/data/bug-14063.php'], [
[
'Assign to protected(set) property Bug14063\Obj::$value.',
31,
],
[
'Assign to protected(set) property Bug14063\Obj::$value.',
34,
],
[
'Assign to protected(set) property Bug14063\Base::$value.',
38,
],
]);
}

#[RequiresPhp('>= 8.5')]
public function testCloneWith(): void
{
Expand Down
39 changes: 39 additions & 0 deletions tests/PHPStan/Rules/Properties/data/bug-14063.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php // lint >= 8.5

declare(strict_types = 1);

namespace Bug14063;

final readonly class Obj
{
public function __construct(public string $value) {}

public function withValue(string $newValue): self
{
return clone($this, ['value' => $newValue]);
}
}

readonly class Base
{
public function __construct(public string $value) {}
}

readonly class Child extends Base
{
public function withValue(string $newValue): self
{
return clone($this, ['value' => $newValue]);
}
}

$obj = new Obj('val');
$newObj = clone($obj, ['value' => 'newVal']);

function test(Obj $obj): void {
clone($obj, ['value' => 'newVal']);
}

function testBase(Base $base): void {
clone($base, ['value' => 'newVal']);
}
Loading