Fix 'format not a string literal and no format arguments [-Werror=format-security]'#8
Open
Eugenpaul wants to merge 1 commit intophusion:masterfrom
Open
Fix 'format not a string literal and no format arguments [-Werror=format-security]'#8Eugenpaul wants to merge 1 commit intophusion:masterfrom
Eugenpaul wants to merge 1 commit intophusion:masterfrom
Conversation
|
Would love to see it merged (would fix bug in our gem - EthWorks/ethereum.rb#11) |
hulajesus
added a commit
to consenlabs/digest-sha3-ruby
that referenced
this pull request
Sep 2, 2017
|
I'd also like to see this merged, it affects the ruby-eth gem as well. |
|
plz merge |
|
please! Thank you! |
|
This gem is abandoned. |
|
an easy workaround would be |
smaximov
added a commit
to smaximov/nixpkgs
that referenced
this pull request
Jan 18, 2019
`digest-sha3` is a C-extension gem which fails to build on Nix because it uses non-literals as format strings which is forbidden by the default Nix hardening settings. There is a pull request to fix that ([1]), but the gem seems to be abandoned. This PR disables the "format" hardening for `digest-sha3`. [1]: phusion/digest-sha3-ruby#8
10 tasks
|
why not merging this? |
|
@mathieujobin I'm not sure why @FooBarWidget could you please take a look at this PR and provide feedback? |
|
Any update on this? This rolls into this new issue if the repo is going to be maintained: #13 |
|
Thank you for the fix. |
|
I published this as |
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add a simple fix. The problem is that at least in Ubuntu gcc has "-Wformat-security" as a default flag, and together with "-Werror=format-security" they lead to an error if fprintf is used without format string (https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security). The issue is #7