Fix: bare except, duplicate TaskStatus, and shell quoting#7
Open
avi8or wants to merge 1 commit intopiercelamb:mainfrom
Open
Fix: bare except, duplicate TaskStatus, and shell quoting#7avi8or wants to merge 1 commit intopiercelamb:mainfrom
avi8or wants to merge 1 commit intopiercelamb:mainfrom
Conversation
- check_working_tree_status() has a bare except that catches
everything and returns {"clean": True}. So if git isn't installed
or something goes wrong, callers just think the tree is clean with
no indication anything failed. Narrowed it to FileNotFoundError and
added an error dict so the caller actually knows what happened.
- TaskStatus is defined identically in both task_storage.py and
impl_tasks.py. Consolidated into task_storage.py so there's a
single definition to maintain.
- Same shell quoting fix as deep-project — unquoted exports in
capture-session-id.py break when paths have spaces in them.
All 146 existing tests pass plus 19 hook tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_working_tree_status() has a bare except that catches everything and returns {"clean": True}. So if git isn't installed or something goes wrong, callers just think the tree is clean with no indication anything failed. Narrowed it to FileNotFoundError and added an error dict so the caller actually knows what happened.
TaskStatus is defined identically in both task_storage.py and impl_tasks.py. Consolidated into task_storage.py so there's a single definition to maintain.
Same shell quoting fix as deep-project — unquoted exports in capture-session-id.py break when paths have spaces in them.
All 146 existing tests pass plus 19 hook tests.