refactor(home): remove releases/changelog consumers + static home stat (#3725)#4222
Conversation
#3725) - remove getChangelogs store action and /changelogs route (releases feature dropped per #3725 product decision) - remove Changelogs link from footer nav in app.development.config.js - update getStatistics: drop releases API call (statistics[1] was releases version number); statistics now updates tasks [0] and users [1] - remove Releases stat from home.development.config.js statistics.content array so indices align with updated getStatistics action - remove releasesNumber from tools.js helper (no longer used) and its unit tests - cross-references Node PR (fix(home): restrict /team fields, remove releases/changelog, add jwt readiness check #3724 #3725 #3718)
|
Warning Review limit reached
More reviews will be available in 56 minutes and 41 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 31 31
Lines 1182 1164 -18
Branches 330 327 -3
==========================================
- Hits 1177 1159 -18
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the remaining changelog/releases surface area from the Home module, updates the Home statistics to no longer depend on a releases API call, and cleans up the related helper/test code.
Changes:
- Removed
/changelogsroute + all Vue-side consumers ofgetChangelogs. - Refactored
getStatistics()to update only Tasks + Users, leaving the remaining stat(s) static. - Deleted the unused
releasesNumberhelper and its unit tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/home/views/home.pages.view.vue | Removes getChangelogs dispatch logic from watcher/created hook. |
| src/modules/home/tests/home.store.unit.tests.js | Drops getChangelogs tests and updates getStatistics expectations to match new indices. |
| src/modules/home/stores/home.store.js | Removes getChangelogs, drops releases API call from getStatistics, and cleans up imports. |
| src/modules/home/router/home.router.js | Removes the /changelogs route. |
| src/modules/home/config/home.development.config.js | Removes the “Releases” statistic entry to align indices with the new stats behavior. |
| src/modules/app/config/app.development.config.js | Removes the footer link to /changelogs. |
| src/lib/helpers/tools.js | Removes the releasesNumber helper and updates default export accordingly. |
| src/lib/helpers/tests/tools.unit.tests.js | Removes releasesNumber unit tests/imports. |
getStatistics was modified in this PR but lacked a JSDoc header. Add description + @returns as expected for async functions.
Summary
getChangelogsstore action fromhome.store.js/changelogsroute fromhome.router.jsapp.development.config.jsgetChangelogs()calls fromhome.pages.view.vue(watcher + created hook)getStatistics: drop releases API call;statistics[0]= tasks,statistics[1]= usersReleasesstat fromhome.development.config.jsstatistics.content (indices aligned)releasesNumberfromtools.jshelper and its unit tests (no longer used anywhere)Cross-reference
Node PR: pierreb-devkit/Node#3735 (fix(home): restrict /team fields, remove releases/changelog, add jwt readiness check #3724 #3725 #3718)
Test plan
npm run lint→ 0 issuesnpm run generateConfig && npm run test:unit→ 120 test files, 1941 tests pass/teampage still works;/changelogsroute removed