Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Changes in this pull request
Resolves #2973
Additional info
This pull request updates the widget creation flow to ensure that the newly created widget's unique
idis used throughout the process, rather than itsname. This improves consistency and allows for more reliable widget handling after creation. The most important changes are:Widget Creation Callback Interface:
createWidgetfunction and its callback so that it now passes the widget'sid(a string) instead of itsnameto theonFinishcallback. This affects both the type definition and the implementation. [1] [2]Widget Creation Implementation:
createWidgetfunction to extract theidfrom the API response after widget creation and pass it to theonFinishcallback, instead of the widget's name.Widget Editor Provider Logic:
WidgetEditorProviderto use the newidparameter in the callback, and to callopenWidget(id, widgetType)after a widget is created, ensuring the correct widget is opened.These changes make the widget creation flow more robust by consistently using the widget's unique identifier.