[DNM]add example for hardcode metrics list#434
Open
nexustar wants to merge 3 commits intopingcap:masterfrom
Open
[DNM]add example for hardcode metrics list#434nexustar wants to merge 3 commits intopingcap:masterfrom
nexustar wants to merge 3 commits intopingcap:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
==========================================
- Coverage 30.11% 28.48% -1.63%
==========================================
Files 50 50
Lines 4218 4213 -5
==========================================
- Hits 1270 1200 -70
- Misses 2778 2845 +67
+ Partials 170 168 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
example metrics are dumped from a tiup-playground deployed local cluster, may not precise |
Contributor
|
@kaaaaaaang I think this should have the "not-merge" label? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes