Skip to content

Conversation

@Frank945946
Copy link
Collaborator

@Frank945946 Frank945946 commented Dec 24, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 31, 2025

@Frank945946: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 772e35a link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Collaborator Author

@Frank945946 Frank945946 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

|------|------|------|
| [`rocksdb.max-manifest-file-size`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#max-manifest-file-size) | 修改 | 默认值从 `128MiB` 修改为 `256MiB`,以避免在单个 TiKV 节点的 SST 文件数量过多时,频繁触发 Manifest 文件的 compaction,从而影响整体性能 [#18889](https://github.com/tikv/tikv/issues/18889) @[glorv](https://github.com/glorv) |
| [`grpc-raft-conn-num`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-raft-conn-num) | 修改 | 默认值从 `1` 修改为 `MAX(1, MIN(4, CPU 核数 / 8))`,当 CPU 核数 ≥ 32 时,最大默认连接数限制为 4 [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |
| [`grpc-concurrency`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-concurrency) | 修改 | 默认值从 `1` 修改为 `grpc-raft-conn-num * 3 + 2` [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [`grpc-concurrency`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-concurrency) | 修改 | 默认值从 `1` 修改为 `grpc-raft-conn-num * 3 + 2` [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |
| [`grpc-concurrency`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-concurrency) | 修改 | 为实现 gRPC 相关线程配置能根据 CPU 核数进行自适应调整,默认值从 `5` 修改为 `grpc-raft-conn-num * 3 + 2` [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |

| 配置参数 | 类型 | 描述 |
|------|------|------|
| [`rocksdb.max-manifest-file-size`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#max-manifest-file-size) | 修改 | 默认值从 `128MiB` 修改为 `256MiB`,以避免在单个 TiKV 节点的 SST 文件数量过多时,频繁触发 Manifest 文件的 compaction,从而影响整体性能 [#18889](https://github.com/tikv/tikv/issues/18889) @[glorv](https://github.com/glorv) |
| [`grpc-raft-conn-num`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-raft-conn-num) | 修改 | 默认值从 `1` 修改为 `MAX(1, MIN(4, CPU 核数 / 8))`,当 CPU 核数 ≥ 32 时,最大默认连接数限制为 4 [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [`grpc-raft-conn-num`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-raft-conn-num) | 修改 | 默认值从 `1` 修改为 `MAX(1, MIN(4, CPU 核数 / 8))`,当 CPU 核数 ≥ 32 时,最大默认连接数限制为 4 [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |
| [`grpc-raft-conn-num`](https://docs.pingcap.com/zh/tidb/v8.5/tikv-configuration-file#grpc-raft-conn-num) | 修改 | 为实现 gRPC 相关线程配置能根据 CPU 核数进行自适应调整,默认值从 `1` 修改为 `MAX(1, MIN(4, CPU 核数 / 8))`,当 CPU 核数 ≥ 32 时,最大默认连接数限制为 4 [#18806](https://github.com/tikv/tikv/issues/18806) @[LykxSassinator](https://github.com/LykxSassinator) |

### 系统变量

- 系统变量 [`tidb_mpp_store_fail_ttl`](https://docs.pingcap.com/zh/tidb/v8.5/system-variables/#tidb_mpp_store_fail_ttl) 默认值从 `60s` 修改为 `0s`,意味着 TiDB 不再需要额外等待即可向新启动的 TiFlash 节点发送查询请求,无需再通过延迟来避免查询失败 [#61826](https://github.com/pingcap/tidb/issues/61826) @[gengliqi](https://github.com/gengliqi)
新建的 v8.5.3 集群可以平滑升级到 v8.5.4。但 v8.5.4 发布包含若干系统变量和配置参数的默认值变更和行为调整,需要注意以下要点:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
新建的 v8.5.3 集群可以平滑升级到 v8.5.4。但 v8.5.4 发布包含若干系统变量和配置参数的默认值变更和行为调整,需要注意以下要点
新建的 v8.5.3 集群可以平滑升级到 v8.5.4。但 v8.5.4 发布包含若干系统变量和配置参数的默认值变更和行为调整,升级时需要注意以下要点

新建的 v8.5.3 集群可以平滑升级到 v8.5.4。但 v8.5.4 发布包含若干系统变量和配置参数的默认值变更和行为调整,需要注意以下要点:

- 系统变量 [`tidb_replica_read`](https://docs.pingcap.com/zh/tidb/v8.5/system-variables/#tidb_replica_read-从-v40-版本开始引入) 从 v8.5.4 开始仅对只读 SQL 语句生效,以提高数据读取的安全性并减少与其他功能的重叠 [#62856](https://github.com/pingcap/tidb/issues/62856) @[you06](https://github.com/you06)
- 大多数变更对于常规升级是安全的,但对于曾进行过性能调优、使用 TiFlash、或对 TiKV compaction 进行了自定义配置的集群,需要仔细检查本节内容。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 大多数变更对于常规升级是安全的,但对于曾进行过性能调优、使用 TiFlash、或对 TiKV compaction 进行了自定义配置的集群,需要仔细检查本节内容。
- 大多数变更对于常规升级是安全的,但对于曾进行过性能调优、包含 TiFlash 节点、或对 TiKV compaction 进行了自定义配置的集群,需要仔细检查本节内容。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants