Skip to content

sql: add note about table aliases in FOR UPDATE OF clause#21489

Open
lilin90 wants to merge 4 commits intopingcap:masterfrom
lilin90:feat/forupdateof-22568
Open

sql: add note about table aliases in FOR UPDATE OF clause#21489
lilin90 wants to merge 4 commits intopingcap:masterfrom
lilin90:feat/forupdateof-22568

Conversation

@lilin90
Copy link
Copy Markdown
Member

@lilin90 lilin90 commented Mar 31, 2026 •
edited
Loading

What is changed, added or deleted? (Required)

Added a note about table aliases in the FOR UPDATE OF clause

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Mar 31, 2026
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2026
@github-actions
Auto-sync: Update Chinese docs from English PR
7894bbe 
Synced from: pingcap/docs#22568
Target PR: pingcap#21489
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lilin90
lilin90 commented Mar 31, 2026
View reviewed changes
@lilin90 lilin90 mentioned this pull request Mar 31, 2026
Merged
14 tasks
@lilin90 lilin90 requested a review from bb7133 March 31, 2026 08:33
@lilin90 lilin90 self-assigned this Mar 31, 2026
@lilin90 lilin90 requested a review from hfxsd March 31, 2026 08:37
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 1, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-01 02:57:40.593592738 +0000 UTC m=+320265.798952795: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2026
@lilin90
Copy link
Copy Markdown
Member Author

lilin90 commented Apr 1, 2026

/test pull-verify

1 similar comment
@lilin90
Copy link
Copy Markdown
Member Author

lilin90 commented Apr 1, 2026

/test pull-verify

@cryo-zd
Copy link
Copy Markdown

cryo-zd commented Apr 1, 2026

LGTM

@lilin90 lilin90 added the lgtm label Apr 1, 2026
@lilin90
Copy link
Copy Markdown
Member Author

lilin90 commented Apr 1, 2026

/retest-required

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 1, 2026

@lilin90: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 1cc5fc5 link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2026
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfxsd hfxsd hfxsd approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@lilin90 lilin90

Labels

lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lilin90 @cryo-zd @hfxsd