glossary: add links to alphabets#22634
Conversation
Restructure glossary.md for improved navigation: convert many term headings from H3 to H2, add a <TabsPanel> component for letter navigation, and insert letter anchor links for each section. Also adjust the frontmatter separator/formatting. Add the missing MONITOR keyword to keywords.md.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the user experience and structural consistency of the documentation. The primary goal is to make the glossary more navigable by introducing alphabetical tab navigation and clearer section headings. Additionally, it ensures the keyword list is up-to-date by including a previously omitted term. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Code Review
This pull request refactors the glossary.md file by introducing a TabsPanel component and adjusting the heading structure for various terms, promoting ### headings to ## and adding <a> tags for letter-based navigation. Additionally, the MONITOR keyword is added to keywords.md. Key feedback for glossary.md includes removing a UTF-8 Byte Order Mark (BOM) character at the beginning of the file for compatibility and ensuring all headings conform to the sentence case rule as specified in the style guide.
I am having trouble creating individual review comments. Click here to see my feedback.
glossary.md (1)
This line starts with a UTF-8 Byte Order Mark (BOM) character (). This character is invisible in many editors but can cause issues with some Markdown parsers and tools. It's best to remove it for compatibility.
---
References
- The style guide emphasizes clarity and readability. Invisible characters like a BOM can lead to unexpected rendering or processing issues, which goes against the principle of clarity. (link)
glossary.md (35)
According to the repository style guide, headings should use sentence case (e.g., ## Configure the cluster). This heading and many others in this file are in Title Case. For consistency and to adhere to the style guide, they should be converted to sentence case.
Here are other headings that also need to be changed:
## Baseline Capturing## Batch Create Table## Cached Table## Coalesce Partition## Column Family (CF)## Common Table Expression (CTE)## Continuous Profiling## Data Definition Language (DDL)## Data Migration (DM)## Data Modification Language (DML)## Development Milestone Release (DMR)## Disaster Recovery (DR)## Distributed eXecution Framework (DXF)## Dynamic Pruning## Garbage Collection (GC)## General Availability (GA)## Global Transaction Identifiers (GTIDs)## Hybrid Transactional and Analytical Processing (HTAP)## In-Memory Pessimistic Lock## Index Merge## Key Management Service (KMS)## Key-Value (KV)## Lightweight Directory Access Protocol (LDAP)## Lock View## Long Term Support (LTS)## Massively Parallel Processing (MPP)## Online Analytical Processing (OLAP)## Online Transaction Processing (OLTP)## Out of Memory (OOM)## PD Control (pd-ctl)## Placement Driver (PD)## Placement Rules## Point Get## Point in Time Recovery (PITR)## Queries Per Second (QPS)## Quota Limiter## Raft Engine## Region Split## Remote Procedure Call (RPC)## Request Unit (RU)## Security Enhanced Mode (SEM)## Stale Read## Static Sorted Table / Sorted String Table (SST)## TiDB Lightning## TiKV MVCC In-Memory Engine (IME)## Timestamp Oracle (TSO)## Top SQL## Transactions Per Second (TPS)## Uniform Resource Identifier (URI)## Universally Unique Identifier (UUID)
Note: Single-word headings, acronyms, and proper names like TiDB or RocksDB do not need to be changed.
## Backup and restore (BR)
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (205)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (211)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (233)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (246)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (284)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (363)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
glossary.md (415)
This heading is in sentence case, which follows the style guide. However, many other headings in this file are in Title Case. To ensure consistency, please apply the same case (preferably sentence case as per the style guide) to all term headings.
References
- The style guide specifies that headings should be in sentence case. For example:
## Configure the cluster. (link)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
Restructure glossary.md for improved navigation: convert many term headings from H3 to H2, add a component for letter navigation, and insert letter anchor links for each section. Also adjust the frontmatter separator/formatting. Add the missing MONITOR keyword to keywords.md.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?