Skip to content

glossary: add links to alphabets#22629

Closed
hfxsd wants to merge 8 commits intopingcap:masterfrom
hfxsd:add-letter-links-in-glossary-21460
Closed

glossary: add links to alphabets#22629
hfxsd wants to merge 8 commits intopingcap:masterfrom
hfxsd:add-letter-links-in-glossary-21460

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Mar 25, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Mar 25, 2026
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is intended to enhance the project's glossary by incorporating links to alphabets, aiming to improve navigation and accessibility within the documentation. While the primary goal is a documentation update, the current patch includes the addition of a temporary markdown file.

Highlights

  • Glossary Enhancement: The pull request's core objective is to enrich the glossary by adding navigational links to alphabets, thereby improving the user experience for documentation readers.
  • Temporary File Included: A new file named temp.md has been introduced, containing simple test content. This file appears to be a placeholder or for testing purposes and does not directly contribute to the stated glossary updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hfxsd hfxsd self-assigned this Mar 25, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a temporary test file, temp.md, which should be removed. The intended changes, specifically adding links to alphabets to the glossary as indicated by the pull request title, are currently missing from this submission.

I am having trouble creating individual review comments. Click here to see my feedback.

temp.md (1)

high

This file appears to be a temporary test file that was accidentally included. It should be removed from this pull request.

Additionally, the changes described in the pull request title ("glossary: add links to alphabets") seem to be missing. Please ensure you commit the intended changes and remove this temporary file.

github-actions bot added a commit to hfxsd/docs that referenced this pull request Mar 25, 2026
Synced from: pingcap/docs-cn#21460
Target PR: pingcap#22629
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 25, 2026
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2026
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2026
@hfxsd
Copy link
Collaborator Author

hfxsd commented Mar 25, 2026

Close this one because there are too many commits

@hfxsd hfxsd closed this Mar 25, 2026
@hfxsd hfxsd reopened this Mar 25, 2026
hfxsd and others added 8 commits March 25, 2026 17:22
@hfxsd hfxsd closed this Mar 25, 2026
@hfxsd hfxsd force-pushed the add-letter-links-in-glossary-21460 branch from 6c9ca74 to da2e26c Compare March 25, 2026 09:24
@ti-chi-bot ti-chi-bot bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2026
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2026
@hfxsd
Copy link
Collaborator Author

hfxsd commented Mar 25, 2026

reopen

1 similar comment
@hfxsd
Copy link
Collaborator Author

hfxsd commented Mar 25, 2026

reopen

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2026

@hfxsd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify da2e26c link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Mar 25, 2026

Replaced by #22634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants