-
Notifications
You must be signed in to change notification settings - Fork 709
restore: update the definition of the parameter --load-stats and the usage of pitr id map (#21078) #22200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
restore: update the definition of the parameter --load-stats and the usage of pitr id map (#21078) #22200
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@Leavrth This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for TiDB's Backup & Restore (BR) tool, enhancing clarity around Point-in-Time Recovery (PITR) ID map management and introducing new features for checkpoint data storage and system table restoration. The changes provide users with more detailed guidance on configuring and understanding BR's behavior, particularly for newer versions, and introduce a more efficient method for restoring system tables. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates documentation related to restore operations, specifically for checkpoint restore and snapshot restore. It introduces new features available from v9.0.0, such as storing checkpoint data in external storage and using --fast-load-sys-tables for physical restore of system tables.
My review focuses on improving the clarity and structure of the documentation. I've identified a critical issue where merge conflict markers were left in br/br-checkpoint-restore.md, which will break the document rendering. I've also suggested a significant restructuring of that document to avoid confusion caused by duplicated section headings and to better present the different methods for storing checkpoint data. Additionally, I've provided suggestions to correct inaccuracies (like 'target cluster' instead of 'external storage'), improve sentence structure for better readability, and ensure consistent formatting.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21078
First-time contributors' checklist
What is changed, added or deleted? (Required)
Note
This PR brings some updates added in #20492, which is also cherry picked into v8.5, as confirmed by @Leavrth.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
--load-statsand the usage of pitr id map docs-cn#20346Do your changes match any of the following descriptions?