-
Notifications
You must be signed in to change notification settings - Fork 710
added cross-account OSS bucket configuration #22632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wildpcww
wants to merge
7
commits into
pingcap:release-8.5
Choose a base branch
from
wildpcww:br-ali-audit-log
base: release-8.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9838e39
cloud-premium: add manual backup support for premium instances
wildpcww fdd5c15
Apply suggestions from code review
hfxsd df26b42
Apply suggestions from code review
hfxsd 03a47b9
Update tidb-cloud/premium/backup-and-restore-premium.md
hfxsd f070954
Apply suggestions from code review
hfxsd 094e0a7
Merge branch 'pingcap:release-8.5' into release-8.5
wildpcww 120659c
docs: add cross-account OSS bucket configuration for Alibaba Cloud au…
wildpcww File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! As a senior technical writer, I've reviewed this section and have a suggestion to improve its technical accuracy, clarity, and adherence to our documentation style guide.
Here's a summary of the proposed changes:
Technical Accuracy:
Actionhas been corrected fromoss:GetObjecttooss:PutObject, which is required for TiDB Cloud to write audit logs. This is to ensure technical accuracy as per the style guide.Principalin the bucket policy has been updated to use the correct format for an Alibaba Cloud RAM role, as the previous format appeared to be for AWS.Clarity and Readability:
<User Account 1>have been replaced with more descriptive ones like<role-account-id>.Style and Formatting:
#####) for better document structure.I've provided a ready-to-commit suggestion that incorporates all these improvements. Thank you for your contribution!
References