Skip to content

[DNM]: avoid meaningless heartbeat #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wk989898 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DNM]: avoid meaningless heartbeat #4401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions downstreamadapter/dispatchermanager/dispatcher_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,9 @@ func (e *DispatcherManager) aggregateDispatcherHeartbeats(needCompleteStatus boo
}

if needCompleteStatus {
if dispatcherItem.GetTryRemoving() {
return
}
Comment on lines +746 to +748
Copy link

@gemini-code-assist gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This check is useful to avoid sending heartbeats for dispatchers that are being removed. The same logic should also be applied to the dispatcherMap loop further down in this function (around line 773) for consistency and to prevent meaningless heartbeats from regular event dispatchers.

if watermark != nil {
eventServiceDispatcherHeartbeat.Append(event.NewDispatcherProgress(id, watermark.CheckpointTs))
} else {
Expand Down