eventcollector: clarify dispatcher session state transitions#5022
eventcollector: clarify dispatcher session state transitions#5022lidezhu wants to merge 24 commits into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request refactors the dispatcherSession and dispatcherConnState logic to implement a more robust state machine for managing dispatcher registrations, specifically improving the coordination between local and remote event services and ensuring the cleanup of stale registrations. The review feedback identified minor typos in the documentation comments within dispatcher_session.go and provided a suggestion for correction.
| // after reset during normal run time, we can filter reduduant syncpoint at event collector side | ||
| // so we just take care of the case that resetTs is same as startTs |
There was a problem hiding this comment.
There are a couple of typos in this comment. reduduant should be redundant and syncpoint should be sync point.
| // after reset during normal run time, we can filter reduduant syncpoint at event collector side | |
| // so we just take care of the case that resetTs is same as startTs | |
| // after reset during normal run time, we can filter redundant sync points at event collector side | |
| // so we just take care of the case that resetTs is same as startTs |
5088f81 to
99564b1
Compare
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note